Support custom loading screen music and images #80
Conversation
- repository info in MapInfo - typos fixed - export progress bar improvements
|
@Insprill added custom loading screen logo support
|
| Validator validator = validators[i]; | ||
|
|
||
| EditorUtility.DisplayProgressBar("Validating map", validator.GetType().ToString(), i / (float)validators.Length); |
There was a problem hiding this comment.
I ran into a situation where part of the validation took a long time. This line makes the progress bar show what validator is running so we can see what it's doing.
There was a problem hiding this comment.
It was already there through, you just moved it below the array access
| @@ -28,6 +29,14 @@ protected override IEnumerator<Result> Validate(Scenes scenes) | |||
| if (mapInfo.name == Names.DEFAULT_MAP_NAME) | |||
| yield return Result.Error($"Your map name cannot be {Names.DEFAULT_MAP_NAME}"); | |||
|
|
|||
| //Loading Screen | |||
| //LoadingScreenImages will be null if the map was built with an older version of Mapify | |||
There was a problem hiding this comment.
This comment doesn't make sense since it's in the exporter. Was it supposed to say something along the lines of LoadingScreenImages will be null if none are configured? I don't recall if Unity would make the array null or empty if it's unset.
There was a problem hiding this comment.
This comment doesn't make sense since it's in the exporter
Not if the map was exported with an older version of Mapify.
There was a problem hiding this comment.
I'm still not following. This is in editor-only code that's only run when you try to export the map. It's never run on an already exported map.
Support custom loading screen music and images and:
untitled.mp4