Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INSD-9439] Add New Locales #363

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,19 @@

### Added

- Add network logs obfuscation support using the new `NetworkLogger.obfuscateLog`
API ([#380](https://github.com/Instabug/Instabug-Flutter/pull/380)).
- Add network logs omission support using the new `NetworkLogger.omitLog`
API ([#382](https://github.com/Instabug/Instabug-Flutter/pull/382)).
- Add the new repro steps configuration
API `Instabug.setReproStepsConfig` ([#388](https://github.com/Instabug/Instabug-Flutter/pull/388)).
- Add network logs obfuscation support using the new `NetworkLogger.obfuscateLog` API ([#380](https://github.com/Instabug/Instabug-Flutter/pull/380)).
- Add network logs omission support using the new `NetworkLogger.omitLog` API ([#382](https://github.com/Instabug/Instabug-Flutter/pull/382)).
- Add the new repro steps configuration API `Instabug.setReproStepsConfig` ([#388](https://github.com/Instabug/Instabug-Flutter/pull/388)).
- Add support for more locales ([#363](https://github.com/Instabug/Instabug-Flutter/pull/363)):
1. Bulgarian
2. Croatian
3. Estonian
4. Greek
5. Latvian
6. Lithuanian
7. Serbian
8. Slovenian
9. Ukrainian

### Changed

Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ android {
}

dependencies {
api 'com.instabug.library:instabug:13.2.0'
api 'com.instabug.library-bdrthermea:instabug:13.2.0'

testImplementation 'junit:junit:4.13.2'
testImplementation "org.mockito:mockito-inline:3.12.1"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,30 +113,39 @@ public T get(Object key) {
public static final ArgsMap<InstabugLocale> locales = new ArgsMap<InstabugLocale>() {{
put("IBGLocale.arabic", InstabugLocale.ARABIC);
put("IBGLocale.azerbaijani", InstabugLocale.AZERBAIJANI);
put("IBGLocale.bulgarian", InstabugLocale.BULGARIAN);
put("IBGLocale.chineseSimplified", InstabugLocale.SIMPLIFIED_CHINESE);
put("IBGLocale.chineseTraditional", InstabugLocale.TRADITIONAL_CHINESE);
put("IBGLocale.croatian", InstabugLocale.CROATIAN);
put("IBGLocale.czech", InstabugLocale.CZECH);
put("IBGLocale.danish", InstabugLocale.DANISH);
put("IBGLocale.dutch", InstabugLocale.NETHERLANDS);
put("IBGLocale.english", InstabugLocale.ENGLISH);
put("IBGLocale.estonian", InstabugLocale.ESTONIAN);
put("IBGLocale.finnish", InstabugLocale.FINNISH);
put("IBGLocale.french", InstabugLocale.FRENCH);
put("IBGLocale.german", InstabugLocale.GERMAN);
put("IBGLocale.greek", InstabugLocale.GREEK);
put("IBGLocale.hungarian", InstabugLocale.HUNGARIAN);
put("IBGLocale.indonesian", InstabugLocale.INDONESIAN);
put("IBGLocale.italian", InstabugLocale.ITALIAN);
put("IBGLocale.japanese", InstabugLocale.JAPANESE);
put("IBGLocale.korean", InstabugLocale.KOREAN);
put("IBGLocale.latvian", InstabugLocale.LATVIAN);
put("IBGLocale.lithuanian", InstabugLocale.LITHUANIAN);
put("IBGLocale.norwegian", InstabugLocale.NORWEGIAN);
put("IBGLocale.polish", InstabugLocale.POLISH);
put("IBGLocale.portugueseBrazil", InstabugLocale.PORTUGUESE_BRAZIL);
put("IBGLocale.portuguesePortugal", InstabugLocale.PORTUGUESE_PORTUGAL);
put("IBGLocale.romanian", InstabugLocale.ROMANIAN);
put("IBGLocale.russian", InstabugLocale.RUSSIAN);
put("IBGLocale.serbian", InstabugLocale.SERBIAN);
put("IBGLocale.slovak", InstabugLocale.SLOVAK);
put("IBGLocale.slovenian", InstabugLocale.SLOVENIAN);
put("IBGLocale.spanish", InstabugLocale.SPANISH);
put("IBGLocale.swedish", InstabugLocale.SWEDISH);
put("IBGLocale.turkish", InstabugLocale.TURKISH);
put("IBGLocale.ukrainian", InstabugLocale.UKRAINIAN);
}};

public static final ArgsMap<Key> placeholders = new ArgsMap<Key>() {{
Expand Down
2 changes: 2 additions & 0 deletions example/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ target 'Runner' do
use_frameworks!
use_modular_headers!

pod 'Instabug', :podspec => 'https://ios-releases.instabug.com/custom/feature-add-more-languages/13.2.0/Instabug.podspec'

flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
end

Expand Down
12 changes: 7 additions & 5 deletions example/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,28 @@ PODS:

DEPENDENCIES:
- Flutter (from `Flutter`)
- Instabug (from `https://ios-releases.instabug.com/custom/feature-add-more-languages/13.2.0/Instabug.podspec`)
- instabug_flutter (from `.symlinks/plugins/instabug_flutter/ios`)
- OCMock (= 3.6)

SPEC REPOS:
trunk:
- Instabug
- OCMock

EXTERNAL SOURCES:
Flutter:
:path: Flutter
Instabug:
:podspec: https://ios-releases.instabug.com/custom/feature-add-more-languages/13.2.0/Instabug.podspec
instabug_flutter:
:path: ".symlinks/plugins/instabug_flutter/ios"

SPEC CHECKSUMS:
Flutter: f04841e97a9d0b0a8025694d0796dd46242b2854
Instabug: aee76898789d17c55b36c7fbaa697e443effe3b1
Flutter: e0871f40cf51350855a761d2e70bf5af5b9b5de7
Instabug: 5e232f2cf23176661d0a29fc04ea8aceb762bae6
instabug_flutter: 8fe63955937c73205d4e71667aea9d56ed8d921b
OCMock: 5ea90566be239f179ba766fd9fbae5885040b992

PODFILE CHECKSUM: f809f4241ff3da61349081a141c44763598f2fbb
PODFILE CHECKSUM: ea25cbe6c323726f092f912d61c39e32afa9e573

COCOAPODS: 1.13.0
COCOAPODS: 1.14.3
9 changes: 9 additions & 0 deletions ios/Classes/Util/ArgsRegistry.m
Original file line number Diff line number Diff line change
Expand Up @@ -116,29 +116,38 @@ + (ArgsDictionary *)locales {
return @{
@"IBGLocale.arabic" : @(IBGLocaleArabic),
@"IBGLocale.azerbaijani" : @(IBGLocaleAzerbaijani),
@"IBGLocale.bulgarian" : @(IBGLocaleBulgarian),
@"IBGLocale.chineseSimplified" : @(IBGLocaleChineseSimplified),
@"IBGLocale.chineseTraditional" : @(IBGLocaleChineseTraditional),
@"IBGLocale.croatian" : @(IBGLocaleCroatian),
@"IBGLocale.czech" : @(IBGLocaleCzech),
@"IBGLocale.danish" : @(IBGLocaleDanish),
@"IBGLocale.dutch" : @(IBGLocaleDutch),
@"IBGLocale.english" : @(IBGLocaleEnglish),
@"IBGLocale.estonian" : @(IBGLocaleEstonian),
@"IBGLocale.finnish" : @(IBGLocaleFinnish),
@"IBGLocale.french" : @(IBGLocaleFrench),
@"IBGLocale.german" : @(IBGLocaleGerman),
@"IBGLocale.greek" : @(IBGLocaleGreek),
@"IBGLocale.hungarian" : @(IBGLocaleHungarian),
@"IBGLocale.italian" : @(IBGLocaleItalian),
@"IBGLocale.japanese" : @(IBGLocaleJapanese),
@"IBGLocale.korean" : @(IBGLocaleKorean),
@"IBGLocale.latvian" : @(IBGLocaleLatvian),
@"IBGLocale.lithuanian" : @(IBGLocaleLithuanian),
@"IBGLocale.norwegian" : @(IBGLocaleNorwegian),
@"IBGLocale.polish" : @(IBGLocalePolish),
@"IBGLocale.portugueseBrazil" : @(IBGLocalePortugueseBrazil),
@"IBGLocale.portuguesePortugal" : @(IBGLocalePortuguese),
@"IBGLocale.romanian" : @(IBGLocaleRomanian),
@"IBGLocale.russian" : @(IBGLocaleRussian),
@"IBGLocale.serbian" : @(IBGLocaleSerbian),
@"IBGLocale.slovak" : @(IBGLocaleSlovak),
@"IBGLocale.slovenian" : @(IBGLocaleSlovenian),
@"IBGLocale.spanish" : @(IBGLocaleSpanish),
@"IBGLocale.swedish" : @(IBGLocaleSwedish),
@"IBGLocale.turkish" : @(IBGLocaleTurkish),
@"IBGLocale.ukrainian" : @(IBGLocaleUkrainian),
};
}

Expand Down
9 changes: 9 additions & 0 deletions lib/src/modules/instabug.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,30 +32,39 @@ enum WelcomeMessageMode { live, beta, disabled }
enum IBGLocale {
arabic,
azerbaijani,
bulgarian,
chineseSimplified,
chineseTraditional,
croatian,
czech,
danish,
dutch,
english,
estonian,
finnish,
french,
german,
greek,
hungarian,
indonesian,
italian,
japanese,
korean,
latvian,
lithuanian,
norwegian,
polish,
portugueseBrazil,
portuguesePortugal,
romanian,
russian,
serbian,
slovak,
slovenian,
spanish,
swedish,
turkish,
ukrainian,
}

enum LogLevel {
Expand Down