Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: merge http plugin into mono-repo #520

Open
wants to merge 10 commits into
base: refactor/monorepo
Choose a base branch
from
Open

Refactor: merge http plugin into mono-repo #520

wants to merge 10 commits into from

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  1. add HTTP network package to monoRepo

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID : MOB-16294

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented Oct 20, 2024 •
edited
Loading

Warnings
⚠️

Coverage for instabug_http_client is less than the expected threshold of 80%

Coverage Report

Label Coverage Status
instabug_flutter 85.3% ✅
instabug_http_client 64.0% ❌

Generated by 🚫 dangerJS against 2d716fa

@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Refactor: monorepo add http package Refactor: add http plugin to mono-repo Oct 21, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Refactor: add http plugin to mono-repo Refactor: merge http plugin to mono-repo Oct 21, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug changed the title Refactor: merge http plugin to mono-repo Refactor: merge http plugin into mono-repo Oct 21, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug marked this pull request as ready for review October 23, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@a7medev a7medev Awaiting requested review from a7medev

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @InstabugCI @AndrewAminInstabug