Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-12845]: Add passing SDK version to the native SDK support #1022

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

[MOB-12845]: Add passing SDK version to the native SDK support #1022

wants to merge 14 commits into from

Conversation

asamiz
Copy link
Contributor

@asamiz asamiz commented Sep 10, 2023 •
edited
Loading

Description of the change

Add the support of passing the RN SDK version to the native SDK by sending it as a second parameter in setCurrentPlatform API.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA Ticket: MOB-12857

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

a7medev and others added 11 commits July 18, 2023 16:04
@a7medev
[MOB-12609] Unify Discard Alert Buttons Strings (#1001)
46cff11 
* Unify discard alert strings

* Update Changelog

* Fix Android tests
@a7medev
[MOB-12640] Unify Repro Steps List Item Title String (#1002)
46a2f95
@asamiz
[MOB-12515] Support React Native 0.73 (#1004)
17a34cd 
* chore(versionSupport): add namespace in build.gradle to support upcoming 0.73 version

* chore(versionSupport): fix PR comments

* chore(versionSupport): fix PR comments

* chore(versionSupport): modify the comment for clarification
@abdelhamid-f-nasser
[MOB-12702] Remove danger ruby package (#1008)
8a73aa3 
Remove danger ruby package to resolve depenndabot git security vulnerability issue.
@abdelhamid-f-nasser
refactor: extract shared crash reporting logic (#1010)
b7c3950 
Jira ID: MOB-12538

- refactor: extract duplicate crash reporting code
- chore: Resolve utils lint issues
- test: add sendCrashReport tests in utils
- test: refactor tests validating sendCrashReport
- chore: exclude local history from .gitignore
- test: refactor errorMock to use TypeError
@abdelhamid-f-nasser
chore: bump up react-native dependencies (#1007)
1f26327 
Jira ID: MOB-12699

- ⚙️ build: upgrade ci Node.js to v18.17.0
- 🪮 style: fix format issues
- 🔧 refactor: migrate deprecated `mocked` imports in favor of `jest-mock`
- ⬆️ chore: bump SDK dependencies (all but TypeScript)
- ✈️ chore(android): migrate to RN 0.72.3
- ⬆️ chore(example): bump react-native, jest and typescript
@abdelhamid-f-nasser
chore: add auto device selection detection (#1009)
15e442b 
Jira ID: MOB-12654
@abdelhamid-f-nasser
feat: report startup crashes on android (#1012)
e1c1063 
Jira ID: MOB-12628, MOB-12689, MOB-12690
@a7medev
fix: update PR link format in changelog (#1017)
8e03969 
Jira ID: MOB-12979
@a7medev
refactor: use anonymous class instead of lambda (#1016)
f59f2b1 
Jira ID: MOB-12977
@asamiz
feat(cpSDKVersion): add passing SDK version to the native sdk support
2815056
@asamiz asamiz marked this pull request as draft September 10, 2023 12:57
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
JavaScript 96.5% ✅
Android 49.6% ✅
iOS 38.1% ✅

Generated by 🚫 dangerJS against 2ae41ea

@asamiz asamiz marked this pull request as ready for review September 10, 2023 22:47
@asamiz asamiz requested review from abdelhamid-f-nasser and a7medev and removed request for abdelhamid-f-nasser September 10, 2023 22:47
@asamiz asamiz marked this pull request as draft September 12, 2023 11:12
Base automatically changed from dev to master September 17, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev Awaiting requested review from a7medev

@abdelhamid-f-nasser abdelhamid-f-nasser Awaiting requested review from abdelhamid-f-nasser

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asamiz @InstabugCI @a7medev @abdelhamid-f-nasser