Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read INSTABUG_APP_TOKEN from env in sourcemap uploading #1222

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  1. support reading INSTABUG_APP_TOKEN variable from env files in automatic sourcemap files uploading

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID: INSD-10736

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@ahmedAlaaInstabug ahmedAlaaInstabug requested a review from a team May 28, 2024 17:01
@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this May 28, 2024
@InstabugCI
Copy link
Collaborator

InstabugCI commented May 28, 2024

Coverage Report

Label Coverage Status
JavaScript 96.3%
Android 48.3%
iOS 42.3%

Generated by 🚫 dangerJS against 6339f8e

Base automatically changed from dev to master June 6, 2024 16:31
@a7medev
Copy link
Contributor

a7medev commented Oct 9, 2024

@ahmedAlaaInstabug Why do we need to configure environment variables in the Gradle project properties on Android? What's the status of this PR?

@a7medev a7medev marked this pull request as draft October 9, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants