Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): fix crash on reporting non fetal crash #1254

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(example): fix crash on reporting non fetal crash #1254

wants to merge 3 commits into from

Conversation

kholood-ea
Copy link
Contributor

Description of the change

Fix example app crash on reporting native non fetal

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

jiraID:MOB-14977

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@kholood-ea kholood-ea self-assigned this Jul 22, 2024
a7medev
a7medev previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

Base automatically changed from dev to master August 4, 2024 15:58
@mzelzoghbi mzelzoghbi dismissed a7medev’s stale review August 4, 2024 15:58

The base branch was changed.

@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from master to dev August 20, 2024 12:20
@ahmedAlaaInstabug ahmedAlaaInstabug changed the base branch from dev to master August 20, 2024 12:21
@a7medev a7medev self-requested a review October 9, 2024 07:20
a7medev
a7medev requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kholood-ea Can you please update this PR on the latest changes on dev so we can get it merged?

a7medev
a7medev requested changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kholood-ea Can we please merge dev into this PR since it got out of sync with it? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev requested changes

@ahmedAlaaInstabug ahmedAlaaInstabug Awaiting requested review from ahmedAlaaInstabug

@AndrewAminInstabug AndrewAminInstabug Awaiting requested review from AndrewAminInstabug

Requested changes must be addressed to merge this pull request.

Assignees

@kholood-ea kholood-ea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kholood-ea @a7medev @abdelhamid-f-nasser