Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable time limit #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

davidoskky
Copy link

📑 Configurable time limit

Adds an option in the config file to set how many minutes should the game last.
15 minutes is not enough with lots of guns.

Moreover, do not count warmup time in game time and display how much warmup time is missing in the scoreboard before the start of the match.

✅ Checks

  • My pull request adheres to the code style of this project.
  • My code requires changes to the documentation.
  • I have updated the documentation, comments as required.
  • I've tested my commits, they work and do not send users to oblivion.

@Shtoyan
Copy link
Member

Shtoyan commented Mar 27, 2023

Woah, thanks for PR.

But your changes for scoreboard doesn't work for me on dedicated server. Did you test it only in solo?

@davidoskky
Copy link
Author

Indeed; I'm sorry.
I'll try later to understand what is not replicating on the server.
I guess it's the bDoingWarmup.

@davidoskky
Copy link
Author

I could not test it on my dedicated server yet, but this looks like it should work.

@Shtoyan
Copy link
Member

Shtoyan commented Mar 30, 2023

Sorry for the late reply. I just tested - Warmup time shows correctly, but not the remaining time after main game starts: aka it's TimeLimit - WarmupTime.

@davidoskky
Copy link
Author

Alright, don't worry. I have got it on my server for testing now and on I'll send you the fixed version either today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants