Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-Ecommerce HW Done #10

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Suklapoddar2223
Copy link

No description provided.

@Suklapoddar2223
Copy link
Author

Here is my project deploy link
https://strong-maamoul-8f61e7.netlify.app/

Copy link
Collaborator

@slmgnm slmgnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just check responsiveness again on all pages, so it looks better for mobile. Fix stretched images.
clean unused code.

}
.product__img{
width: 100%;
height: 15rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can try here: object-fit: cover; so it won't stretch the image.

style.css Outdated
Comment on lines 311 to 322
.cart__item input{
flex: 0.1;
}
.cart__item-img{
flex: 0.2;
width:15rem ;
height: 10rem;
}
.cart__item-desciption{
flex: 0.4;
}
.cart__payment{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some margin or padding on smaller screen.

gap: 3rem;
min-height: 60vh;
}
.contact .card{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check it here in media query, make it less than 45rem.

index.html Outdated
Comment on lines 73 to 89

<!-- <div class="banner container">
<marquee class="banner__title" behavior="scroll" direction= "left" width="60%" height="100px">Valentine's Day Special Offer</marquee>

</div>
<div class= "banner">
<img src="./unsplash8.jpg" alt="hotel pic" class="img" >

<button class="btn btn__header">Click for Direct Booking</button>



</div> -->




Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean unused code

Comment on lines +162 to +193

<!-- footer section starts here -->
<!-- <footer class="footer">

<div class="footer__para">
<p>
<h2><i class="fas fa-map-marker"></i>Utrecht, Netherlands</h2>
<h2><i class="fa fa-phone"></i> +310678945367</h2>
</p>
</div>
<div class="footer__time">
<h3>Opening Hours</h3>
<h3>Monday to Thursday : 12.00 to 23.00</h3>
<h3>Friday to Sunday : 12.00 to 01.00</h3>
</div>
<div class="footer__subscription">

<label for="subscribe">Subscribe For Newsletter:</label>
<input type="email" id="subscribe" name="subscribe" class="footer__sub" placeholder="Enter Your Email">
<button class="btn btn__sub">Subscribe</button>
</div>
<nav class="footer-nav">
<a href="#" class="footer__link">Follow Us :<br/><i class="fab fa-facebook footer__icon"><br/></i> Lets' Meat</a>
</nav>
<div class="copy-right">
<p class="copyright">&copy; Copyright 2023 Lets'Meat.All Rishts Resarved</p>
</div>

</footer>

-->

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean unused code

@slmgnm slmgnm added the graded label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants