-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-Ecommerce HW Done #10
base: main
Are you sure you want to change the base?
Conversation
Here is my project deploy link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, just check responsiveness again on all pages, so it looks better for mobile. Fix stretched images.
clean unused code.
} | ||
.product__img{ | ||
width: 100%; | ||
height: 15rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can try here: object-fit: cover; so it won't stretch the image.
style.css
Outdated
.cart__item input{ | ||
flex: 0.1; | ||
} | ||
.cart__item-img{ | ||
flex: 0.2; | ||
width:15rem ; | ||
height: 10rem; | ||
} | ||
.cart__item-desciption{ | ||
flex: 0.4; | ||
} | ||
.cart__payment{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some margin or padding on smaller screen.
gap: 3rem; | ||
min-height: 60vh; | ||
} | ||
.contact .card{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check it here in media query, make it less than 45rem.
index.html
Outdated
|
||
<!-- <div class="banner container"> | ||
<marquee class="banner__title" behavior="scroll" direction= "left" width="60%" height="100px">Valentine's Day Special Offer</marquee> | ||
|
||
</div> | ||
<div class= "banner"> | ||
<img src="./unsplash8.jpg" alt="hotel pic" class="img" > | ||
|
||
<button class="btn btn__header">Click for Direct Booking</button> | ||
|
||
|
||
|
||
</div> --> | ||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean unused code
|
||
<!-- footer section starts here --> | ||
<!-- <footer class="footer"> | ||
|
||
<div class="footer__para"> | ||
<p> | ||
<h2><i class="fas fa-map-marker"></i>Utrecht, Netherlands</h2> | ||
<h2><i class="fa fa-phone"></i> +310678945367</h2> | ||
</p> | ||
</div> | ||
<div class="footer__time"> | ||
<h3>Opening Hours</h3> | ||
<h3>Monday to Thursday : 12.00 to 23.00</h3> | ||
<h3>Friday to Sunday : 12.00 to 01.00</h3> | ||
</div> | ||
<div class="footer__subscription"> | ||
|
||
<label for="subscribe">Subscribe For Newsletter:</label> | ||
<input type="email" id="subscribe" name="subscribe" class="footer__sub" placeholder="Enter Your Email"> | ||
<button class="btn btn__sub">Subscribe</button> | ||
</div> | ||
<nav class="footer-nav"> | ||
<a href="#" class="footer__link">Follow Us :<br/><i class="fab fa-facebook footer__icon"><br/></i> Lets' Meat</a> | ||
</nav> | ||
<div class="copy-right"> | ||
<p class="copyright">© Copyright 2023 Lets'Meat.All Rishts Resarved</p> | ||
</div> | ||
|
||
</footer> | ||
|
||
--> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean unused code
No description provided.