e commerce project #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can you please make the folder structures a bit nicer.
For example, move the stylings to a folder and the html files to a different folder and name them accordingly. Let me know once you've done that, so that I can come back to reviewing the codes in more detail.
|
Done. took some time to understand how to solve merge conflict, have never done before |
slmgnm
reviewed
Jan 31, 2023
Comment on lines
+32
to
+34
| <li class="list__item"><a class="nav-link" href="login.html" target="_blank"><i class="fa-solid fa-user list__icon"></i> Login</a></li> | ||
| <li class="list__item"><a class="nav-link" href="#main-footer"><i class="fa-solid fa-address-card list__icon"></i> Contacts</a></li> | ||
| <li class="list__item"><a class="nav-link" href="cart.html" target="_blank"><i class="fa-solid fa-cart-shopping list__icon"></i> Cart</a></li> |
There was a problem hiding this comment.
Remove target from anchor links, so user can stay on the same page and not opening new tabs.
Comment on lines
+22
to
+25
| body{ | ||
| width: 100rem; | ||
| margin: auto; | ||
| } |
There was a problem hiding this comment.
Check the width on media query to have some responciveness.
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Rajdhani:wght@300;400;500;600;700&display=swap" rel="stylesheet"> | ||
| </head> | ||
| <body> |
There was a problem hiding this comment.
It is good to add a thumbnail of the product with the name of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the moment cite is not responsive in any page