Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecommerce project #17

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Lily-Ibrahimi77
Copy link

No description provided.

@anisul-Islam anisul-Islam self-assigned this Jan 26, 2023
Copy link
Collaborator

@slmgnm slmgnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Just check responsiveness of form fields and add margin to buttons.
Maybe it is better to keep one full card for product and give it margin on the side. 👍

Comment on lines +77 to +83

<!--<div class="aside__btns">
<span><button class="chat__btn">Chat with us</button>
</span>
<span><button class="fdback__btn">Give us a feedback</button>
</span>
</div>-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up unused code

Comment on lines +94 to +100
<ul class="footer-list">
<li class="footer-list-item"><a href="/products/user-acount.html" target="main-frame">Account</a></li>
<li class="footer-list-item"><a href="/products/cart.html" target="main-frame">Cart</a></li>
<li class="footer-list-item"><a href="/products/signIn.html" target="main-frame">Sign in</a></li>
<li class="footer-list-item"><a href="/products/signUp.html" target="main-frame">Sign up</a></li>
<li class="footer-list-item"><a href="/contact.html" target="main-frame">Contact</a></li>
</ul>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give bottom margin to cart and user, especially for mobile.

@slmgnm slmgnm self-assigned this Jan 31, 2023
@slmgnm slmgnm added the graded label Jan 31, 2023
@anisul-Islam anisul-Islam removed their assignment Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants