-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ecommerce project #17
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Just check responsiveness of form fields and add margin to buttons.
Maybe it is better to keep one full card for product and give it margin on the side. 👍
|
||
<!--<div class="aside__btns"> | ||
<span><button class="chat__btn">Chat with us</button> | ||
</span> | ||
<span><button class="fdback__btn">Give us a feedback</button> | ||
</span> | ||
</div>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up unused code
<ul class="footer-list"> | ||
<li class="footer-list-item"><a href="/products/user-acount.html" target="main-frame">Account</a></li> | ||
<li class="footer-list-item"><a href="/products/cart.html" target="main-frame">Cart</a></li> | ||
<li class="footer-list-item"><a href="/products/signIn.html" target="main-frame">Sign in</a></li> | ||
<li class="footer-list-item"><a href="/products/signUp.html" target="main-frame">Sign up</a></li> | ||
<li class="footer-list-item"><a href="/contact.html" target="main-frame">Contact</a></li> | ||
</ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give bottom margin to cart and user, especially for mobile.
No description provided.