Skip to content

Change docstring in can_access_peer method #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

Change docstring in can_access_peer method #2082

merged 1 commit into from
May 16, 2025

Conversation

ndgrigorian
Copy link
Collaborator

This PR follows up on #2077 by adjusting the docstring for the can_access_peer method

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

antonwolfy
antonwolfy approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, LGTM

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_226 ran successfully.
Passed: 1114
Failed: 5
Skipped: 119

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.972%. remained the same
when pulling ca4f41c on peer-access-follow-up
into 3d71288 on master.

@ndgrigorian ndgrigorian merged commit a391844 into master May 16, 2025
70 of 84 checks passed
@ndgrigorian ndgrigorian deleted the peer-access-follow-up branch May 16, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy