Permit Cython 3.1.0 for Python 3.13 #2118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2118/index.html |
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_54 ran successfully. |
ndgrigorian
force-pushed
the
permit-cython-3.1.0
branch
from
f646868 to
eb0e6c7
Compare
|
Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_78 ran successfully. |
ndgrigorian
requested review from
antonwolfy,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
reviewed
Jul 25, 2025
| @@ -4,4 +4,8 @@ set -e | |||
|
|
|||
| ${PYTHON} -c "import dpctl; print(dpctl.__version__)" | |||
| ${PYTHON} -m dpctl -f | |||
| ${PYTHON} -m pytest -q -ra --disable-warnings --cov dpctl --cov-report term-missing --pyargs dpctl -vv | |||
| if ${PYTHON} --version 2>&1 | grep -q '^Python 3\.13'; then | |||
| ${PYTHON} -m pytest -q -ra --disable-warnings --pyargs dpctl -vv | |||
There was a problem hiding this comment.
Would it make sense to add a comment why there is a dependency on python version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes logic which limits Cython 3.1.0 for Python 3.13