Skip to content

add Dask interface #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add Dask interface #184

wants to merge 1 commit into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 15, 2025

resolves #5

@vtavana vtavana self-assigned this May 15, 2025
@vtavana vtavana force-pushed the dask-interface branch 6 times, most recently from 9275f59 to 4be1793 Compare May 16, 2025 04:53
@vtavana vtavana requested a review from Copilot May 16, 2025 18:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new Dask FFT interface to the mkl_fft package, resolving issue #5.

  • Added a new module to wrap Dask FFT functions with appropriate tests in mkl_fft/interfaces/dask_fft.py and mkl_fft/tests/third_party/dask/test_dask_fft.py.
  • Updated interface aggregations, documentation, and CI/conda configuration files to include the new Dask dependency.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Added "dask" as a test dependency.
mkl_fft/tests/third_party/dask/test_dask_fft.py New tests for the Dask FFT interface with several FFT function validations.
mkl_fft/tests/test_interfaces.py Extended interface tests to include the new dask_fft interface.
mkl_fft/interfaces/dask_fft.py Introduced the Dask FFT wrapper by leveraging dask.array.fft.
mkl_fft/interfaces/init.py Updated to import the new dask_fft module.
mkl_fft/interfaces/README.md Updated documentation to reflect support for Dask.
conda-recipe and workflow files Updated dependency and test commands to include Dask.
CHANGELOG.md Documented the addition of the Dask FFT interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Dask interface to mkl_fft
1 participant