Skip to content

change to dynamic linking and add interface and threading layers #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented May 7, 2025

resolves IntelPython/mkl_fft#165

Main branch

import numpy as np, mkl_umath
n = 2**31
data = np.ones(n)
mkl_umath.absolute(data)
# Intel oneMKL ERROR: Parameter 1 was incorrect on entry to vdAbs.
# array([0., 0., 0., ..., 0., 0., 0.], shape=(2147483648,))

This branch

import numpy as np, mkl_umath
n = 2**31
data = np.ones(n)
mkl_umath.absolute(data)
# array([1., 1., 1., ..., 1., 1., 1.], shape=(2147483648,))

@vtavana vtavana self-assigned this May 7, 2025
@vtavana vtavana force-pushed the add-ilp64 branch 8 times, most recently from 69cb600 to 1bfa605 Compare May 8, 2025 00:59
@vtavana vtavana marked this pull request as ready for review May 8, 2025 02:00
@ndgrigorian
Copy link
Collaborator

In general I don't see a problem with this change, but changing a dependency is a pretty big tweak.

@ekomarova @AndresGuzman-Ballen is there any way Intel NumPy tests can be run with this branch to make sure it doesn't introduce any major failures?

@AndresGuzman-Ballen
Copy link
Contributor

@ndgrigorian I suppose I could point mkl_umath's commit in numpy-2.2.5 branch to this branch, but I'd prefer doing that after I can get all subpackages to build and pass tests in our CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intel oneMKL ERROR: Parameter 1 was incorrect on entry to vdAbs. when numpy array is too large
3 participants