Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu2204 kernel patches combined with scripts for downloading, patching, and building kernel modules #10489

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jpswensen
Copy link

This pull request includes two scripts and two patches. The scripts are for building the patched kernel modules on Ubuntu 22.04 (Jammy) for both Raspberry Pi 4 and for x86_64. The patches that are includes are a monolithic single patch for the baseline kernels on these two architectures, rather than the split up patches that are used for a lot of other platforms and Linux versions.

I also spent a considerably amount of time simplifying and commenting the patching scripts so that it could be used as a tutorial about what is actually going on during the patching process and included a preface that describes the differences between the RSUSB interface and the V4L interface. These are all details that are located at various places in the github Issues tracker, but though it would be a good idea to coalesce/distill them all in one place.

I also think that by not trying to target all versions of Ubuntu and all architectures that is makes the process a lot more simple and understandable to someone who is coming at this from scratch and might need to update it for a newer kernel. A lot of the stuff in the patch-realsense-ubuntu-lts.sh script is a bit confusing because some much of it is carryover from having to deal with very old kernels (e.g. pre 5.x kernels)

@dmipx
Copy link
Contributor

dmipx commented Jun 22, 2022

Hi @jpswensen!
Can you squash commits?
Thanks.

@Minipada
Copy link

Minipada commented Jul 6, 2022

Hey @jpswensen, this would be wondeful to merge this so we can simply apt-install on ros rolling and humble. Thanks!

…4 Jammy for both rpi4 and x86_64

Updates to the patch scripts fo fix some directory errors
@jpswensen
Copy link
Author

Hi @jpswensen! Can you squash commits? Thanks.

I think I squashed those correctly. I am not a github expert, so I may have done that wrong.

@Minipada
Copy link

@jpswensen I tested on my pc and I think you need to:

# origin is IntelRealSense/librealsense
git fetch origin/master
git checkout origin/master

# Your fork branch, this one from this PR
git merge --squash jp/rpi4_ubuntu2204_kernel_patchescombined
git commit -m "YOUR_NEW_COMMIT_MESSAGE"

git log

Then you verify you have only one commit difference

image

Also you can check the commit content with git diff, ensure all your modifications are correct

git diff origin/master

If so you will need to git push force to this branch jp/rpi4_ubuntu2204_kernel_patchescombined once again. This will replace your 4 commits you currently have on it by a single one

@Nir-Az Nir-Az requested a review from dmipx September 8, 2022 18:50
@Nir-Az
Copy link
Collaborator

Nir-Az commented Sep 8, 2022

@dmipx Is this PR still relevant after we merged the Jammy patches?

@jdpc86
Copy link

jdpc86 commented Nov 1, 2022

it seems that i need this driver to have my F200 camera work properly on Ubuntu 22.10...any luck with this for 22.04? can this be ported over to 22.10?

# enough that it would be a good launching point for trying to adapt to your
# distribution and your board.

# Some background on the patched kernel modules. I had to go hunting for this information in a bunch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here. I too had to hunt for this, and would love to share more in the documentation on installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants