Re-use device buffer in yuy2 cuda helper #11737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new device buffer class which only re-allocated on demand - make the buffer instances static to preserve them between frames Github issue: IntelRealSense#11692 (comment)
attiladoor
commented
Apr 27, 2023
| static T* allocateBuffer(std::size_t const reserve_size) | ||
| { | ||
| T* datatemp{nullptr}; | ||
| cudaMalloc(&datatemp, reserve_size * sizeof(T)); |
There was a problem hiding this comment.
maybe i can add an assert to the return value of cudaMalloc and cudaFree above. What do you think?
| @@ -284,7 +286,7 @@ void rscuda::unpack_yuy2_cuda_helper(const uint8_t* h_src, uint8_t* h_dst, int n | |||
|
|
|||
| cudaDeviceSynchronize(); | |||
There was a problem hiding this comment.
In my opinion, this is unnecessary, but better to use async copy and use the same stream across the whole function and do a stream syncronization before we return from this function. By that we can avoid extra syncing, however the gain would be probably not very significant.
|
Thanks for the PR, we will investigate this issue & fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #11692 (comment)
Nsight systems profiling:
As we can see, there is no allocation being done at the yuy2 conversion