android-examples-recording-plus #11920
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple program, introduce the openCV library, realize pressing the snapshot button, save the aligned color map, pseudo-color depth map, and grayscale depth map locally on the Android device, and use the getData method to save The depth data is a .csv file.
|
Hi @oddityyyy
and one more question, why do saving .jpg files instead of extracting pictures from the recorded .bag file? Thx. |
Small comment about 3, we prefer using ExternalProject_Add on Cmake on top of submodule. |
AndrewBloom
reviewed
Apr 12, 2024
| static { | ||
| if(!OpenCVLoader.initDebug()) | ||
| { | ||
| Log.d("opencv","初始化失败"); |
| @@ -1,3 +1,4 @@ | |||
| <resources> | |||
| <string name="app_name">RS Capture</string> | |||
| <string name="message1">拍照</string> | |||
| @@ -1,14 +1,14 @@ | |||
| apply plugin: 'com.android.application' | |||
|
|
|||
| android { | |||
| compileSdkVersion 30 | |||
| compileSdkVersion 28 | |||
There was a problem hiding this comment.
Compile sdk should be the latest not an old one
| versionCode 1 | ||
| versionName "1.0" | ||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | ||
| testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner" |
There was a problem hiding this comment.
Why this? androidx is now the preferred way
| @@ -20,11 +20,11 @@ android { | |||
|
|
|||
| dependencies { | |||
| implementation fileTree(dir: 'libs', include: ['*.jar']) | |||
| implementation 'androidx.appcompat:appcompat:1.2.0' | |||
| implementation 'androidx.constraintlayout:constraintlayout:2.0.4' | |||
| implementation 'com.android.support:appcompat-v7:28.0.0' | |||
There was a problem hiding this comment.
here too androidX is the preferred way
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| <android.support.constraint.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Solve #9989 #10310 #10007 #8551 #5446，and give a unified and complete solution.
Make changes on the basis of the https://github.com/IntelRealSense/librealsense/tree/master/wrappers/android/examples/recording example in the Android sample program, introduce the openCV library, realize pressing the snapshot button, save the aligned color map, pseudo-color depth map, and grayscale depth map locally on the Android device, and use the getData method to save The depth data is a .csv file.
Does this pull request potentially affect existing recording functions？
No.
Snapshot and recording are two independent processes and do not affect each other. Users can choose to press the snapshot button to save the frame data at a certain moment to the Android local or press the recording button to record a complete bag file for a certain period of time according to their own needs.