Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenNI2 Stream Mirroring Compatibility Hack #12412

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

starmaid
Copy link

See Issue #12363 reported last week. Thanks to @MartyG-RealSense for extra info.

All these comments apply to the file /wrappers/openni2/src/Rs2StreamProps.cpp

Where I started looking at this, librealsense does not support stream mirroring, and the getProperty(ONI_STREAM_PROPERTY_MIRRORING) always returns false.

OpenNI2 Viewer will crash if isPropertySupported(ONI_STREAM_PROPERTY_MIRRORING) returns true, but then when attempting to set the property it recieves ONI_STATUS_NOT_SUPPORTED. This was the behavior before my change.

Some Closed-source OpenNI2 Scanning apps call setProperty(ONI_STREAM_PROPERTY_MIRRORING) without checking if its supported first. By returning OK, we can allow these programs (Skanect, ReconstructMe, probably others) to function normally.

The downside is that some OpenNI2 developer may attempt to mirror the video (without checking if the property is supported), the wrapper will return OK, and the video will not be mirrored. This may not be intuitive. However, if they then check getProperty(ONI_STREAM_PROPERTY_MIRRORING) they will still receive false, so this is consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant