UVC device power #13082
Draft
UVC device power #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evice power in one while the other still needs it
maloel
reviewed
Jul 8, 2024
| auto & dev = environment::get_instance().get_uvc_device( info.unique_id ); | ||
| if( ! dev ) | ||
| { | ||
| dev = get_backend()->create_uvc_device( info ); |
There was a problem hiding this comment.
This actually does a set...
I.e., the next line means nothing.
But this is also dangerous if multiple threads are in this same loop.
maloel
reviewed
Jul 8, 2024
| return _device_info_uid_to_uvc_device[uvc_device_info_uid]; | ||
| } | ||
|
|
||
| void set_uvc_device( const std::string & uvc_device_info_uid, std::shared_ptr< platform::uvc_device > & device ) |
There was a problem hiding this comment.
This looks OK but the device is NEVER removed! I don't think that's what we want.
We want it to be removed when the last reference to it is gone.
There was a problem hiding this comment.
Note that not only is it never removed but if we have new info with the same ID then we'll use the old one. I don't know if this will ever happen - but it'd be worth checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT ONLY, to share the code we have discussed during our meeting