Update ImGui v1.90.9 #13392
Open
Update ImGui v1.90.9 #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
Nir-Az
reviewed
Oct 6, 2024
|
Note that once ready we will have to make a UI sanity to this change. |
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
from
5ea88b8
to
48807d1
Compare
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
Nir-Az
reviewed
Nov 10, 2024
| /* License: Apache 2.0. See LICENSE file in root directory. */ | ||
| /* Copyright(c) 2024 Intel Corporation. All Rights Reserved. */ | ||
|
|
||
| //Overloading imgui functions to accommodate realsense GUI |
There was a problem hiding this comment.
So we must include this header only after the IMGUI header?
There was a problem hiding this comment.
I'm not sure what you meant, we include this header if we use one of the helper\overloading functions, we do use it almost every time we use imgui.
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
6 times, most recently
from
ff903b0
to
b1881af
Compare
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
from
b1881af
to
dd72548
Compare
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
from
844ac13
to
54a0dc3
Compare
Nir-Az
reviewed
Nov 20, 2024
common/ux-alignment.cpp
Outdated
| @@ -49,8 +50,7 @@ bool is_gui_aligned(GLFWwindow *win) | |||
|
|
|||
| glfwSwapBuffers(win); | |||
|
|
|||
| ImGui_ImplGlfw_NewFrame(); | |||
| ImGui::NewFrame(); | |||
| ImGui::PushNewFrame(); | |||
There was a problem hiding this comment.
Why do we reuse the ImGui namespace and not place all of our special functions under RsImGui?
There was a problem hiding this comment.
you are right, at first it was mostly overloading functions and in order not to change the code I used the ImGui namespace but now it has helper functions, so it makes more sense to change it.
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
4 times, most recently
from
79ed478
to
86d8f64
Compare
Noy-Zini
force-pushed
the
Update_ImGui_v1.90.9
branch
from
86d8f64
to
4ed121d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traced on: [LRS-1129]