Workaround to support FLASH WRITE for MIPI camera D457 #13642
Conversation
src/ds/ds-device-common.cpp
Outdated
| // This is a WORKAROUND to support MIPI camera D457. | ||
| // If the packet size is more than 128 bytes, FLASH_WRITE is not working as expected. | ||
| // Revert this line after fixing the issue. | ||
| packet_size = std::min(packet_size, 128); |
There was a problem hiding this comment.
This is for all D400 devices? not MIPI only?
There was a problem hiding this comment.
Right now it is for all. Maybe for D500 devices as well.
There was a problem hiding this comment.
Updated it to only apply this workaround for D457.
Arun-Prasad-V
force-pushed
the
mipi_flash_write
branch
from
50574fc to
73674cc
Compare
| @@ -569,7 +569,7 @@ namespace librealsense | |||
| } | |||
| set_hw_monitor_for_auto_calib(_hw_monitor); | |||
|
|
|||
| _ds_device_common = std::make_shared<ds_device_common>(this, _hw_monitor); | |||
| _ds_device_common = std::make_shared<ds_device_common>(this, _hw_monitor, (_pid == ds::RS457_PID)? true : false); | |||
There was a problem hiding this comment.
I see on this common class we have another place where we distinguish between D400 and d500
if( auto dev = dynamic_cast< d400_device * >( _owner ) ) return dev->get_raw_depth_sensor();
So we can see if it's D457 by reading the camera name instead of passing this bool.
What do you think? which way is nicer?
There was a problem hiding this comment.
will check it.
|
@Arun-Prasad-V is this ready for review? |
yes. |
[Tracked on LRS-472]