-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add about page and book image #493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelseymcmahon
temporarily deployed
to
BuildAndUploadImage
June 4, 2024 23:40 — with
GitHub Actions
Inactive
kelseymcmahon
had a problem deploying
to
Production
June 4, 2024 23:45 — with
GitHub Actions
Failure
kelseymcmahon
temporarily deployed
to
BuildAndUploadImage
June 4, 2024 23:59 — with
GitHub Actions
Inactive
kelseymcmahon
had a problem deploying
to
Production
June 5, 2024 00:04 — with
GitHub Actions
Failure
kelseymcmahon
changed the title
Mcmahon/338 add book page
feat: 338-337-336 add book page
Jun 5, 2024
kelseymcmahon
changed the title
feat: 338-337-336 add book page
feat: Add about page and book image
Jun 5, 2024
kelseymcmahon
temporarily deployed
to
BuildAndUploadImage
June 5, 2024 00:11 — with
GitHub Actions
Inactive
kelseymcmahon
temporarily deployed
to
BuildAndUploadImage
June 5, 2024 00:17 — with
GitHub Actions
Inactive
kelseymcmahon
had a problem deploying
to
Production
June 5, 2024 00:22 — with
GitHub Actions
Failure
BenjaminMichaelis
approved these changes
Jun 5, 2024
BenjaminMichaelis
force-pushed
the
mcmahon/338-add-book-page
branch
from
June 5, 2024 20:20
a0735bc
to
254edcf
Compare
BenjaminMichaelis
temporarily deployed
to
BuildAndUploadImage
June 5, 2024 20:20 — with
GitHub Actions
Inactive
BenjaminMichaelis
had a problem deploying
to
Development
June 5, 2024 20:22 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #338 #337 #336
Edits:
Would like to create some kind of graphic to fill this area, created a story(#494):
Also, I think I need to update the root css colors to match the parser project side to the added web colors here. There is a bit of a mismatch at the moment on the generated pages.
Ensure that your pull request has followed all the steps below: