Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add about page and book image #493

Merged
merged 17 commits into from
Jun 5, 2024

Conversation

kelseymcmahon
Copy link
Contributor

@kelseymcmahon kelseymcmahon commented Jun 4, 2024

Description

Fixes: #338 #337 #336

Edits:

  • Adding some UI updates to the site, including some nicer colors and a slightly nicer navigation UI/UX
  • Added an about page
  • Added book to about/home pages
  • Better mobile nav bar
image image image

Would like to create some kind of graphic to fill this area, created a story(#494):

image

Also, I think I need to update the root css colors to match the parser project side to the added web colors here. There is a bit of a mismatch at the moment on the generated pages.

Ensure that your pull request has followed all the steps below:

  • Code compilation
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@kelseymcmahon kelseymcmahon temporarily deployed to BuildAndUploadImage June 4, 2024 23:40 — with GitHub Actions Inactive
@kelseymcmahon kelseymcmahon temporarily deployed to BuildAndUploadImage June 4, 2024 23:59 — with GitHub Actions Inactive
@kelseymcmahon kelseymcmahon changed the title Mcmahon/338 add book page feat: 338-337-336 add book page Jun 5, 2024
@kelseymcmahon kelseymcmahon changed the title feat: 338-337-336 add book page feat: Add about page and book image Jun 5, 2024
@kelseymcmahon kelseymcmahon temporarily deployed to BuildAndUploadImage June 5, 2024 00:11 — with GitHub Actions Inactive
@kelseymcmahon kelseymcmahon marked this pull request as ready for review June 5, 2024 00:12
@kelseymcmahon kelseymcmahon temporarily deployed to BuildAndUploadImage June 5, 2024 00:17 — with GitHub Actions Inactive
@BenjaminMichaelis BenjaminMichaelis force-pushed the mcmahon/338-add-book-page branch from a0735bc to 254edcf Compare June 5, 2024 20:20
@BenjaminMichaelis BenjaminMichaelis temporarily deployed to BuildAndUploadImage June 5, 2024 20:20 — with GitHub Actions Inactive
@BenjaminMichaelis BenjaminMichaelis enabled auto-merge (squash) June 5, 2024 20:20
@BenjaminMichaelis BenjaminMichaelis merged commit 4749174 into main Jun 5, 2024
6 of 7 checks passed
@BenjaminMichaelis BenjaminMichaelis deleted the mcmahon/338-add-book-page branch June 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add book cover
2 participants