-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review (not for merge) #10
Open
MaksGovor
wants to merge
137
commits into
collaborators-review
Choose a base branch
from
main
base: collaborators-review
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
137 commits
Select commit
Hold shift + click to select a range
cfc1f82
added package*.json files
13466b5
-m removed unnecessary react code and files
1d72878
add dot files
c9b7e02
changed dot files
d3b3cf7
configured react
b722652
add code of conduct and contributing
d63591c
improved package.json and added yarn.lock
fc347d1
Init project env
MaksGovor 022d326
implement login page
Honchar007 c1c472b
Merge pull request #1 from Intelligent-Cloud-System/feature/register-…
Honchar007 f9ea037
implement register page and validation
Honchar007 41921c3
Merge pull request #2 from Intelligent-Cloud-System/feature/register-…
Honchar007 4a5354e
add swagger generate
tedi4t 618822c
generate swagger clients
tedi4t eefd6e7
auth integration
tedi4t 9175182
small style changes
tedi4t dd01ca6
injectFirst
tedi4t 2e8ac45
Merge pull request #3 from Intelligent-Cloud-System/feature/auth-inte…
MaksGovor 04925df
Add husky pre-commit
MaksGovor 93c8db1
Merge branch 'dev' into feature/add-husky
MaksGovor e17941c
add auto token refresh
tedi4t 79a887f
Merge pull request #4 from Intelligent-Cloud-System/feature/add-husky
tedi4t f0a5ef4
generate-clients
tedi4t ac67f3a
Merge pull request #5 from Intelligent-Cloud-System/feature/auth-inte…
MaksGovor 5de1228
Add favicon & logo
MaksGovor c9aa5ef
Add base layout
MaksGovor 9401016
feature\implement-upload-ui
Honchar007 5f95f57
add notification hook for errors
tedi4t 195b6d8
Change nav structure
MaksGovor 06c5778
small changes
tedi4t e0ee9b2
add all implement of nav
MaksGovor 0f9e3d5
Full implementation navbar
MaksGovor b8c507a
Restore App.tsx
MaksGovor ebb585a
Merge pull request #7 from Intelligent-Cloud-System/feature/applicati…
MaksGovor b633027
query client
tedi4t 2b247e6
small changes
tedi4t ab62539
implement upload page
Honchar007 bd11058
Merge pull request #9 from Intelligent-Cloud-System/feature/query-client
tedi4t 6d6aee3
Fix review issues
MaksGovor a95cf76
Merge pull request #8 from Intelligent-Cloud-System/feature/navigation
tedi4t f4cfc40
merge dev
tedi4t 9397478
Fix imports
MaksGovor 2f806b3
removed unnecessary code, add wrapper for navbar
tedi4t dc1eea1
renamed navigation
tedi4t 80e44af
improved code style
tedi4t 715ee8b
merge dev
tedi4t fac3b8a
Delete env
Honchar007 4afcf92
Remove unused file and change imports
Honchar007 55958fe
Update README.md
MaksGovor abea766
add file uploading
tedi4t 38cce57
updated clients
tedi4t 5122237
updated clients
tedi4t 4dd049f
user context
tedi4t a91f19f
Merge pull request #11 from Intelligent-Cloud-System/feature/user-con…
tedi4t 8864a5f
merge dev
tedi4t 68a4806
updated useAuthTokenRefresh
0a6010e
small style changes
3089bd0
Implement Files Page
MaksGovor 95bd6f5
Merge pull request #12 from Intelligent-Cloud-System/feature/layout-f…
tedi4t a1cd60d
updated gitignore
6957f17
add uploading files with drag and drop
6599581
process while uploading file
f4c7523
add deleting files
15e7413
Fix file size in uploads
MaksGovor b8e85da
Implement user page
MaksGovor cc59434
add file saving
4208aaf
add disabled button
a48a5fe
small changes
73ee045
Merge pull request #13 from Intelligent-Cloud-System/feature/implemen…
tedi4t dc4497e
Merge branch 'dev' into feature/user-page
MaksGovor 148f281
Fix routes
MaksGovor 6d95def
Add user to nav pannel
MaksGovor 1b231bb
Add user page to navigation
MaksGovor 31a2eb3
Add user to user-page
MaksGovor 8706995
Fix size avatar
MaksGovor 53b8c5a
small fix
MaksGovor 4b714f6
Add templorary solution for logout
MaksGovor 3f976f9
Fix user registration mutation
MaksGovor 844c1a5
Fix review issues
MaksGovor d18b021
fixed bug with logout
919d6ab
Fix mutation entity
MaksGovor 4e4847f
small changes
c73c402
Merge pull request #16 from Intelligent-Cloud-System/fix/registration…
tedi4t 0ee4a5a
updated app routes
c4608be
Fix layout
MaksGovor d28790f
Merge branch 'feature/user-page' of github.com:Intelligent-Cloud-Syst…
MaksGovor 9690364
changed files endpoint
6c92cc8
Merge pull request #15 from Intelligent-Cloud-System/feature/user-page
tedi4t 3844d94
Merge pull request #17 from Intelligent-Cloud-System/dev
tedi4t 3f71487
Update README.md
tedi4t 6642134
fix dependencies
MaksGovor f2d96d7
Merge branch 'dev' of github.com:Intelligent-Cloud-System/ics-fronten…
MaksGovor 11d18d1
Merge branch 'dev' into main
MaksGovor 0c834f1
Fix: updated git hooks accordingly new scripts in package.json
MaksGovor 7d962f1
Feature: folder views
MaksGovor 2349234
Feature: add folders routing & change file model view
MaksGovor ee81f86
Merge pull request #18 from Intelligent-Cloud-System/fix/git-hooks
MaksGovor 9d8f0a0
Fix: small style fixes
MaksGovor 445310c
theme
f4ce723
Feature: folder creating
MaksGovor 07bc6d3
Merge branch 'dev' into feature/file-folder-pretty-view
MaksGovor 2966d42
Add theming
MaksGovor 713cfc8
Feature: smart buttons
MaksGovor aed8e2b
Fix: restyling items
MaksGovor 919a297
Fix: Removed the ability to select objects from multiple folders
MaksGovor 6eb2dc1
Feat: update clients
MaksGovor 4ffda8f
Feat: add single checking items
MaksGovor 32a5a96
Feature: Add deleting files & folders
MaksGovor d30e342
Feat: uploading files
MaksGovor c220188
Feat: use react dropzone
MaksGovor 3b3f040
Feature: generate clients for downloading files
MaksGovor 6cd51bf
Feature: add download single file
MaksGovor f65c3f5
Fix: fix code formatting
MaksGovor 0a50602
Fix: fix repeating code
MaksGovor a23eede
Fix: small fixes
MaksGovor be2fe32
Fix: fix styles logic
MaksGovor 5bbe697
Feat: use addaptive scroll bar in files container
MaksGovor ee458cc
Feat: update clients
MaksGovor d89243b
Fix: using default import
MaksGovor 761f908
Rename downloadFilesByLink to downloadFilesFromSignedUrls
MaksGovor 2274c49
Fix: rename existingContent to content
MaksGovor 1d565f3
Fix: use onError method for Error handling
MaksGovor af3d74a
Merge pull request #19 from Intelligent-Cloud-System/feature/file-fol…
MaksGovor fc3755d
Merge pull request #20 from Intelligent-Cloud-System/dev
MaksGovor 45c4b24
add .idea to gitignore
62a80a3
ws
126b46d
Update src/hooks/socket/useSocket.ts
tedi4t 12bfd3c
Merge pull request #21 from Intelligent-Cloud-System/feature/ws
tedi4t cd190d4
Merge pull request #22 from Intelligent-Cloud-System/dev
tedi4t 33ab648
Fix: update formatting
MaksGovor fa1d346
Fix: delete unused static
MaksGovor b317816
linter run
2336fc2
Merge pull request #23 from Intelligent-Cloud-System/refactor
tedi4t 0ab8cc2
Merge pull request #24 from Intelligent-Cloud-System/dev
tedi4t 6bae370
Feature: generate new clients && fix: fixed generation logic
MaksGovor 1cd383e
Fix: fixed creating bg colour for avatars
MaksGovor 809856c
Merge pull request #26 from Intelligent-Cloud-System/dev
MaksGovor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
SKIP_PREFLIGHT_CHECK=true | ||
REACT_APP_CORE_URL=http://localhost:5000 | ||
REACT_APP_CLIENT_ID=clien_id | ||
REACT_APP_CLIENT_SECRET=client_secret | ||
REACT_APP_REGION=eu-central-1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
lib | ||
lib-scripts | ||
lib-temp | ||
temp | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{ | ||
"root": true, | ||
"parser": "@typescript-eslint/parser", | ||
"plugins": ["react", "react-hooks", "@typescript-eslint", "prettier"], | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:react/recommended", | ||
"plugin:@typescript-eslint/eslint-recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"react-app", | ||
"prettier" | ||
], | ||
"settings": { | ||
"react": { | ||
"pragma": "React", | ||
"version": "detect" | ||
}, | ||
"import/external-module-folders": ["node_modules"], | ||
"import/resolver": { | ||
"node": { | ||
"extensions": [".ts", ".tsx", ".js", ".jsx"], | ||
"moduleDirectory": ["node_modules", "src/"] | ||
} | ||
} | ||
}, | ||
"rules": { | ||
"@typescript-eslint/ban-types": 0, | ||
"@typescript-eslint/explicit-function-return-type": 0, | ||
"@typescript-eslint/explicit-module-boundary-types": 0, | ||
"@typescript-eslint/no-explicit-any": 0, | ||
"@typescript-eslint/no-var-requires": 0, | ||
"@typescript-eslint/ban-ts-comment": 0, | ||
"@typescript-eslint/no-non-null-assertion": 0, | ||
"@typescript-eslint/no-empty-function": 0, | ||
// We are using React 17 so we can disable this rules | ||
"react/prop-types": 0, | ||
"react/display-name": 0, | ||
"react/jsx-uses-react": "off", | ||
"react/react-in-jsx-scope": "off", | ||
// Make prettier code formatting suggestions more verbose. | ||
"prettier/prettier": [ | ||
"error", | ||
{}, | ||
{ | ||
"usePrettierrc": true | ||
} | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,104 +1,16 @@ | ||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
lerna-debug.log* | ||
|
||
# Diagnostic reports (https://nodejs.org/api/report.html) | ||
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json | ||
|
||
# Runtime data | ||
pids | ||
*.pid | ||
*.seed | ||
*.pid.lock | ||
|
||
# Directory for instrumented libs generated by jscoverage/JSCover | ||
lib-cov | ||
|
||
# Coverage directory used by tools like istanbul | ||
coverage | ||
*.lcov | ||
|
||
# nyc test coverage | ||
.nyc_output | ||
|
||
# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) | ||
.grunt | ||
|
||
# Bower dependency directory (https://bower.io/) | ||
bower_components | ||
|
||
# node-waf configuration | ||
.lock-wscript | ||
|
||
# Compiled binary addons (https://nodejs.org/api/addons.html) | ||
build/Release | ||
|
||
# Dependency directories | ||
node_modules/ | ||
jspm_packages/ | ||
|
||
# TypeScript v1 declaration files | ||
typings/ | ||
|
||
# TypeScript cache | ||
*.tsbuildinfo | ||
.idea/ | ||
|
||
# Optional npm cache directory | ||
.npm | ||
|
||
# Optional eslint cache | ||
.eslintcache | ||
|
||
# Microbundle cache | ||
.rpt2_cache/ | ||
.rts2_cache_cjs/ | ||
.rts2_cache_es/ | ||
.rts2_cache_umd/ | ||
|
||
# Optional REPL history | ||
.node_repl_history | ||
|
||
# Output of 'npm pack' | ||
*.tgz | ||
|
||
# Yarn Integrity file | ||
.yarn-integrity | ||
|
||
# dotenv environment variables file | ||
.env | ||
.env.test | ||
|
||
# parcel-bundler cache (https://parceljs.org/) | ||
.cache | ||
|
||
# Next.js build output | ||
.next | ||
|
||
# Nuxt.js build / generate output | ||
.nuxt | ||
dist | ||
|
||
# Gatsby files | ||
.cache/ | ||
# Comment in the public line in if your project uses Gatsby and *not* Next.js | ||
# https://nextjs.org/blog/next-9-1#public-directory-support | ||
# public | ||
|
||
# vuepress build output | ||
.vuepress/dist | ||
|
||
# Serverless directories | ||
.serverless/ | ||
|
||
# FuseBox cache | ||
.fusebox/ | ||
|
||
# DynamoDB Local files | ||
.dynamodb/ | ||
# Swagger files | ||
temp | ||
|
||
# TernJS port file | ||
.tern-port | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn lint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
||
# dependencies | ||
/node_modules | ||
/.pnp | ||
.pnp.js | ||
|
||
# testing | ||
/coverage | ||
|
||
# production | ||
/build | ||
/lib-temp | ||
|
||
# misc | ||
.DS_Store | ||
.env.local | ||
.env.development.local | ||
.env.test.local | ||
.env.production.local | ||
|
||
npm-debug.log* | ||
.idea | ||
.eslintcache |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package.json | ||
public/ | ||
node_modules/ | ||
build | ||
lib | ||
lib-scripts | ||
src/clients |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
{ | ||
"semi": true, | ||
"singleQuote": true, | ||
"jsxSingleQuote": true, | ||
"bracketSpacing": true, | ||
"jsxBracketSameLine": false, | ||
"arrowParens": "avoid", | ||
"useTabs": true, | ||
"tabWidth": 2, | ||
"printWidth": 100, | ||
"trailingComma": "all", | ||
"endOfLine": "auto" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,128 @@ | ||
# Contributor Covenant Code of Conduct | ||
|
||
## Our Pledge | ||
|
||
We as members, contributors, and leaders pledge to make participation in our | ||
community a harassment-free experience for everyone, regardless of age, body | ||
size, visible or invisible disability, ethnicity, sex characteristics, gender | ||
identity and expression, level of experience, education, socio-economic status, | ||
nationality, personal appearance, race, religion, or sexual identity | ||
and orientation. | ||
|
||
We pledge to act and interact in ways that contribute to an open, welcoming, | ||
diverse, inclusive, and healthy community. | ||
|
||
## Our Standards | ||
|
||
Examples of behavior that contributes to a positive environment for our | ||
community include: | ||
|
||
- Demonstrating empathy and kindness toward other people | ||
- Being respectful of differing opinions, viewpoints, and experiences | ||
- Giving and gracefully accepting constructive feedback | ||
- Accepting responsibility and apologizing to those affected by our mistakes, | ||
and learning from the experience | ||
- Focusing on what is best not just for us as individuals, but for the | ||
overall community | ||
|
||
Examples of unacceptable behavior include: | ||
|
||
- The use of sexualized language or imagery, and sexual attention or | ||
advances of any kind | ||
- Trolling, insulting or derogatory comments, and personal or political attacks | ||
- Public or private harassment | ||
- Publishing others' private information, such as a physical or email | ||
address, without their explicit permission | ||
- Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
|
||
## Enforcement Responsibilities | ||
|
||
Community leaders are responsible for clarifying and enforcing our standards of | ||
acceptable behavior and will take appropriate and fair corrective action in | ||
response to any behavior that they deem inappropriate, threatening, offensive, | ||
or harmful. | ||
|
||
Community leaders have the right and responsibility to remove, edit, or reject | ||
comments, commits, code, wiki edits, issues, and other contributions that are | ||
not aligned to this Code of Conduct, and will communicate reasons for moderation | ||
decisions when appropriate. | ||
|
||
## Scope | ||
|
||
This Code of Conduct applies within all community spaces, and also applies when | ||
an individual is officially representing the community in public spaces. | ||
Examples of representing our community include using an official e-mail address, | ||
posting via an official social media account, or acting as an appointed | ||
representative at an online or offline event. | ||
|
||
## Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported to the community leaders responsible for enforcement at | ||
. | ||
All complaints will be reviewed and investigated promptly and fairly. | ||
|
||
All community leaders are obligated to respect the privacy and security of the | ||
reporter of any incident. | ||
|
||
## Enforcement Guidelines | ||
|
||
Community leaders will follow these Community Impact Guidelines in determining | ||
the consequences for any action they deem in violation of this Code of Conduct: | ||
|
||
### 1. Correction | ||
|
||
**Community Impact**: Use of inappropriate language or other behavior deemed | ||
unprofessional or unwelcome in the community. | ||
|
||
**Consequence**: A private, written warning from community leaders, providing | ||
clarity around the nature of the violation and an explanation of why the | ||
behavior was inappropriate. A public apology may be requested. | ||
|
||
### 2. Warning | ||
|
||
**Community Impact**: A violation through a single incident or series | ||
of actions. | ||
|
||
**Consequence**: A warning with consequences for continued behavior. No | ||
interaction with the people involved, including unsolicited interaction with | ||
those enforcing the Code of Conduct, for a specified period of time. This | ||
includes avoiding interactions in community spaces as well as external channels | ||
like social media. Violating these terms may lead to a temporary or | ||
permanent ban. | ||
|
||
### 3. Temporary Ban | ||
|
||
**Community Impact**: A serious violation of community standards, including | ||
sustained inappropriate behavior. | ||
|
||
**Consequence**: A temporary ban from any sort of interaction or public | ||
communication with the community for a specified period of time. No public or | ||
private interaction with the people involved, including unsolicited interaction | ||
with those enforcing the Code of Conduct, is allowed during this period. | ||
Violating these terms may lead to a permanent ban. | ||
|
||
### 4. Permanent Ban | ||
|
||
**Community Impact**: Demonstrating a pattern of violation of community | ||
standards, including sustained inappropriate behavior, harassment of an | ||
individual, or aggression toward or disparagement of classes of individuals. | ||
|
||
**Consequence**: A permanent ban from any sort of public interaction within | ||
the community. | ||
|
||
## Attribution | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
version 2.0, available at | ||
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html. | ||
|
||
Community Impact Guidelines were inspired by [Mozilla's code of conduct | ||
enforcement ladder](https://github.com/mozilla/diversity). | ||
|
||
[homepage]: https://www.contributor-covenant.org | ||
|
||
For answers to common questions about this code of conduct, see the FAQ at | ||
https://www.contributor-covenant.org/faq. Translations are available at | ||
https://www.contributor-covenant.org/translations. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Contributing | ||
|
||
## Pull Requests | ||
|
||
Before open pull request please follow checklist: | ||
|
||
- [ ] all existing tests pass (npm t) | ||
- [ ] tests that cover the new functionality are written and passed | ||
- [ ] the style and format of the code corresponds to the style of the organization (npm run fmt) | ||
|
||
## Issues | ||
|
||
There are two reasons to open an issue: | ||
|
||
- Bug report | ||
- Feature request | ||
|
||
For bug reports please describe the bug with a clear and concise description, | ||
steps to reproduce the behavior, expected behavior, | ||
provide OS, Browser, and version of app. | ||
|
||
For feature request describe the solution you'd like to be released. | ||
|
||
Please don't open an issue to ask questions. | ||
|
||
Issues on GitHub are intended to be related to problems and feature requests | ||
so we recommend not using this medium to ask them here grin. Thanks for | ||
understanding! | ||
|
||
If you have a question, please check out our support groups and channels for | ||
developers community: | ||
|
||
Telegram: | ||
|
||
- Uryn Dmytro: https://t.me/tedi4t | ||
- Govoruha Maxim: https://t.me/Maksgovorrr | ||
- Gonchar Andriy: https://t.me/Hemingwai |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
#Some code should be here |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add sonar, it's always usefull