RELTEC-12278: support raw approvers/watchers #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstollin
previously approved these changes
Nov 22, 2024
mplushnikov
requested changes
Nov 22, 2024
| func (s *Impl) copyStringList(list []string) []string { | ||
| if len(list) > 0 { | ||
| copyList := []string{} | ||
| for _, approver := range list { |
There was a problem hiding this comment.
Funktioniert builtin copy() nicht für strings?
Also einfach:
copyList := make([]string, len(list))
copy(copyList, list)
KRaffael
force-pushed
the
RELTEC-12278-support-github-ssh-urls
branch
from
af935b0 to
882b78c
Compare
mplushnikov
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Checklist