Remove DIRECTORYNAMEP check in EDITCALLERS #2123
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that (EDITCALLERS 'xxx 'UNICODE) works.
UNICODE is both a directory and a file. The DIRECTORYNAMEP test in EDITCALLERS means that nothing happens if called as above. (It would work 'UNCODE. instead of 'UNICODE).
As near as I can tell, nothing breaks if that test is removed--the file is found and the directory doesn't seem to show up.