Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge (rebase) Cleanup-character-IO-interfaces with master #356

Merged
merged 45 commits into from
Jul 30, 2021

Conversation

masinter
Copy link
Member

  • Cleanup of character IO interface
  • Clean out \NSIN etc
  • MODERNIZE: added dragging for fixed-menu windows
  • UNICODE: Added Greek to the default set
  • FASLOAD: EOL conversion in FASL::READ-TEXT
  • LLREAD: Added meta as a CHARACTERSETNAME
  • APRINT FILEIO LLREAD: \OUTCHAR now a closed function
  • LLKEY: call CHARCODE.DECODE directory in \KEYACTION1
  • WHEELSCROLL: re-enable on AFTERMAKESYS/SYSOUT FORMS
  • ABASIC: NILL and ZERO change from LAMBDA NOBIND to LAMBDA NIL
  • MASTERSCOPE: Added WHEREIS as last-resort for CONTAINS
  • POSTSCRIPTSTREAM: use standard \OUTCHAR conventions
  • Recompile with right EXPORTS.ALL
  • Fix POSTSCRIPTSTREAM
  • POSTSCRIPTSTREAM gets its own external format
  • Minor fix
  • Compile-time warning about EXPORTS.ALL
  • MODERNIZE: Modern button fn has same args as the original
  • Fixed another glitch in the MODERNIZE arglist thing
  • FILEWATCH: added missing record field
  • Update FILEWATCH.LCOM
  • Eliminating record/type name conflicts
  • Compile away open calls to \OUTCHAR, add loadups/full.database
  • Remove garbage library/XCCS
  • Next step: Remove open input-character calls, factor XCCS to separate file
  • Lots of residual cleanup for XCCS isolation
  • Delete old file MACINTERFACE (migrated to MODERNIZE)
  • Eliminate straggling NS calls: LAFITE, READINTERPRESS
  • Typo
  • READINTERPRESS: removed CHARSET
  • MODERNIZE: Interface to control title-bar response (for Notecards)
  • Many changes for external format name consistency
  • Put :FORMAT in file info, fix TEDIT plaintext hardcopy
  • Getting the format in the file-info
  • Another fileinfo glitch
  • CLIPBOARD -UNICODE: Make UTF8 to UTF-8 to match standards
  • MODERNIZE: fix bug in MODERWINDOW
  • External format as MAKEFILE option, LOAD applies the file's format
  • Compilers respect DEFINE-FILE-INFO format
  • MODERNIZE: little glitch
  • Delete old FILEIO.LCOM
  • More edge cases of external format thru MAKEFILE, PRETTY, PRETTYFILEINDEX etc.
  • FILEBROWSER: Can SEE UTF-8 Lisp sourcefile
  • INSPECT: Better macro for inspecting readtables
  • recompile changed files and do new loadup

rmkaplan added 30 commits July 27, 2021 20:23
Committing this branch for further testing.  I know at least that the TTY output stream somehow is defaulting to :XCCS, which is wrong, but I haven't yet found the interface for that.
No top-level calls to the NS specific functions, just to the generic \OUTCHAR etc.

Updated full.database
They can be dragged by their title bars
Also made spelling of default-externalformats consistent with FILEIO
EOL's printed as LF's will be read as EOL
meta,a maps to 1,a now.  But slowly propagating this to TEDIT, SEDIT, etc will make it easier to change the coding of meta characters, e.g. as part of a Unicode transition.
Minor cleanup, avoid typical user entry and APPLY*
Also sets up mappings in the \COMMANDKEYACTIONS, whatever that is
So that things like Masterscope don't break
Looks at the WHEREIS database, if present, for FNS and FUNCTIONS if it has no other information.  . WHO CONTAINS ANY CALLING FOO works, but not the inverse:  . WHO DOES FUM CONTAIN.  We still need to figure out why the CONTAINS table isn't populated
Now uses generic \OUTCHAR to get the proper function from the stream (or default)
Some of the macros weren't correct.
Cleaner separation between external \OUTCHAR and internal BOUT
\TEDIT.BUTTONEVENTFN actually takes a second STREAM argument.  I don't see where it is ever called with that.  The modernize replacement binds that argument, but it isn't being passed to the original.
Mostly just qualifying references, more work to get BIGBITMAP stuff out of ADISPLAY and to eliminate ambiguity of LINE record (now XXLINE in XXGEOM)
Mostly new LCOMS where \OUTCHAR calls were compiled open
Old tools for reading wikipedia XCCS tables, sources/XCCS will deal with XCCS external format
… file

XCCS is the default, but can be swapped out (eventually) by setting a few variables, without recompiling everything
@masinter
Copy link
Member Author

I haven’t finished the review of PR #348, but I wanted to pick up some changes that were made to master.
(the 5 second delay at sysout start, for example). Here's how I made this

mkdir new
cd new
git clone https://github.com/interlisp/medley
cd medley
git checkout Cleanup-character-IO-interfaces
git rebase master

which went into a loop where it would complain about conflicts, I’d do

git checkout Cleanup-character-IO-interfaces -- library/RDSYS library/RDSYS.LCOM library/exports.all loadups/whereis.hash loadups/*.dribble loadups/*.sysout loadups/full.database sources/ABASIC.LCOM sources/LLETHER.LCOM
git rebase --continue

and then exit the edit window that popped up

Then I did a loadup-all
Then I ran GATHER-INFO for the effect of loading records needed to
Recompile LLETHER and ABASIC

Then I did a new loadup-all
I then did a ‘start-release merge-ron-cleanup’ to make a medley and maiko release.

(I’m pretty sure it’s wrong to have combined medley + maiko releases. )

@masinter masinter requested a review from rmkaplan July 28, 2021 22:24
Copy link
Contributor

@rmkaplan rmkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@masinter masinter merged commit 4efe2f9 into master Jul 30, 2021
@nbriggs
Copy link
Contributor

nbriggs commented Jul 30, 2021

What is
create mode 100644 sources/LLREAD.XLCOM
doing in this??

@masinter masinter deleted the merge-ron-master branch August 17, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants