Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize filling kv cache kernel in pytorch engine #1251

Merged
merged 9 commits into from
Mar 11, 2024
Merged

optimize filling kv cache kernel in pytorch engine #1251

merged 9 commits into from
Mar 11, 2024

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Mar 6, 2024

  • optimize fill_kv_cache kernel, remove host computation and context update.
  • rename context args

@RunningLeon
Copy link
Collaborator

test ok for two models using opencompass
1710149820093

RunningLeon
RunningLeon approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 changed the title Torch optimize fill kv cache optimize filling kv cache kernel in pytorch engine Mar 11, 2024
@lvhan028 lvhan028 merged commit 1fcd6d3 into InternLM:main Mar 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grimoire @RunningLeon @AllentDan @lvhan028