Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llama3.1 chat template #2862

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix llama3.1 chat template #2862

merged 2 commits into from
Dec 16, 2024

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Dec 6, 2024

It seems https://huggingface.co/meta-llama/Llama-3.1-8B-Instruct/blob/main/tokenizer_config.json says:

image

i.e. July 26 instead July 23.


Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 requested a review from AllentDan December 9, 2024 12:17
@lvhan028 lvhan028 added the Bug:P2 label Dec 9, 2024
@AllentDan
Copy link
Collaborator

Not a big deal. https://www.llama.com/docs/model-cards-and-prompt-formats/llama3_1 gives 23 July 2024

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Dec 10, 2024

Interesting! Then llama itself is inconsistent about this...

@lvhan028
Copy link
Collaborator

Hi, @fzyzcjy
Thanks for your contribution
This PR didn't pass the unit test.
Can you fix it?
https://github.com/InternLM/lmdeploy/actions/runs/12192401746/job/34297273083?pr=2862

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Dec 13, 2024

Sure, done!

@lvhan028 lvhan028 merged commit abd90db into InternLM:main Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants