-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix args type in docstring #2888
Conversation
Hi, @Galaxy-Husky pip install pre-commit
cd lmdeploy # the root dir of lmdeploy repo
pre-commit install
pre-commit run --all-files |
Hi, I've run into two problems.
Could you tell me how to fix them? |
I haven't met this issue.
Please make characters in each line is not greater than 79. |
Fix lint error
@lvhan028 |
Don't worry. That's because the GPUs in the runner is occupied by others. This PR has nothing to do with it. |
Motivation
I've noticed that several args types in the docstring don't match the types in type hints.
Modification
Replace
List[Dict]
withList[List[Dict]]]
.