[feature] Graceful termination of background threads in LlamaV2 #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhoroshev
changed the title
akhoroshev
commented
Sep 24, 2023
| @@ -188,7 +193,9 @@ class Allocator<AllocatorType::CUDA>: public IAllocator { | |||
| { | |||
| TM_LOG_DEBUG(__PRETTY_FUNCTION__); | |||
| while (!pointer_mapping_->empty()) { | |||
| free((void**)(&pointer_mapping_->begin()->first)); | |||
There was a problem hiding this comment.
- it is UB to change key of unordered map
- memory type information (host or device) was missed
lzhangzz
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for LlamaV2's infinite destructor call.
A bug in the cuda allocator (in destructor) has also been fixed.