Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build from source with MPI & NCCL in other directories #471

Closed
wants to merge 1 commit into from
Closed

fix: build from source with MPI & NCCL in other directories #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

cmake_minimum_required(VERSION 3.11 FATAL_ERROR) # for PyTorch extensions, version should be greater than 3.13
cmake_policy(SET CMP0074 NEW)
project(TurboMind LANGUAGES CXX CUDA)

find_package(CUDA 10.2 REQUIRED)
Expand Down Expand Up @@ -265,8 +266,8 @@ print(torch._C._GLIBCXX_USE_CXX11_ABI,end='');"
endif()

if (BUILD_MULTI_GPU)
list(APPEND COMMON_HEADER_DIRS ${MPI_INCLUDE_PATH})
list(APPEND COMMON_LIB_DIRS /usr/local/mpi/lib)
list(APPEND COMMON_HEADER_DIRS ${MPI_CXX_INCLUDE_DIRS})
list(APPEND COMMON_HEADER_DIRS ${NCCL_INCLUDE_DIRS})
endif()

if(USE_TRITONSERVER_DATATYPE)
Expand Down Expand Up @@ -347,7 +348,7 @@ add_library(transformer-shared SHARED

if (BUILD_MULTI_GPU)
target_link_libraries(transformer-shared PUBLIC
-lmpi
${MPI_CXX_LIBRARIES}
${NCCL_LIBRARIES}
)
endif()
Expand Down
2 changes: 1 addition & 1 deletion src/turbomind/utils/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ add_library(mpi_utils STATIC mpi_utils.cc)
set_property(TARGET mpi_utils PROPERTY POSITION_INDEPENDENT_CODE ON)
set_property(TARGET mpi_utils PROPERTY CUDA_RESOLVE_DEVICE_SYMBOLS ON)
if (BUILD_MULTI_GPU)
target_link_libraries(mpi_utils PUBLIC mpi logger)
target_link_libraries(mpi_utils PUBLIC ${MPI_CXX_LIBRARIES} logger)
endif()

add_library(nccl_utils STATIC nccl_utils.cc)
Expand Down
Loading