make IPv6 compatible, safe run for coroutine interrupting #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2023
tpoisonooo
reviewed
Sep 27, 2023
tpoisonooo
approved these changes
Sep 28, 2023
|
I ran into this IPv6 problem and it seems can be sovled after I checkout to this pr. So I decide to leave a mark here. Will there be another Reviewer that can make the fix be merged soon? Thanks for your efforts. |
Conflicts: lmdeploy/serve/openai/api_server.py
lvhan028
reviewed
Oct 9, 2023
lvhan028
approved these changes
Oct 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#463
#408 ctrl+C
fix api_client.py reuse the old session