Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch engine config #908

Merged
merged 6 commits into from
Jan 8, 2024
Merged

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Jan 4, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028
Copy link
Collaborator

lvhan028 commented Jan 5, 2024

可以 from lmdeploy.pytorch import EngineConfig 吗?和 from lmdeploy.turbomind import EngineConfig 对称

@lvhan028
Copy link
Collaborator

lvhan028 commented Jan 5, 2024

model.py中增加了一个best_match_model,可以从文件路径中模糊匹配得到对话模板的名字,这样chat.py的时候可以少输入positional argument model_name

@lvhan028
Copy link
Collaborator

lvhan028 commented Jan 5, 2024

chat 失败了。命令

python lmdeploy/pytorch/chat.py /nvme/shared_data/InternLM/internlm-chat-7b

error:

Traceback (most recent call last):
  File "lmdeploy/pytorch/chat.py", line 137, in <module>
    fire.Fire(main)
  File "/home/lvhan/.conda/envs/triton/lib/python3.8/site-packages/fire/core.py", line 141, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/home/lvhan/.conda/envs/triton/lib/python3.8/site-packages/fire/core.py", line 475, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/home/lvhan/.conda/envs/triton/lib/python3.8/site-packages/fire/core.py", line 691, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "lmdeploy/pytorch/chat.py", line 96, in main
    if step >= tm_model.session_len:
TypeError: '>=' not supported between instances of 'int' and 'NoneType'

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit c658f9a into InternLM:main Jan 8, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants