Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added color contrast to the active option in dropdown menu of navbar #901

Merged

Conversation

sahitya-chandra
Copy link
Contributor

@sahitya-chandra sahitya-chandra commented Feb 14, 2025

Description

Added a background-color #ffffff26 to show the active option inside the dropdown menu of navbar separately.
Fixed the grey color of main text of that active option for better visibility.

Related issue

fixed #899

How Has This Been Tested?

I have tested the changes locally.

Screenshots (if appropriate):

Screenshot from 2025-02-14 08-12-04

Screenshot from 2025-02-14 08-15-17

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sahitya-chandra
Copy link
Contributor Author

@dpgiakatos Sir Please review this code.

@dpgiakatos dpgiakatos self-requested a review February 14, 2025 04:37
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dpgiakatos dpgiakatos merged commit a556e33 into InternetHealthReport:master Feb 14, 2025
6 checks passed
@sahitya-chandra sahitya-chandra deleted the 899-color-contrast-fix branch February 14, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add color contrast in the active dropdown options of navbar
2 participants