-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GHA cache restore any cache from current month if dependencies do not match #510
Conversation
@@ -95,7 +103,11 @@ jobs: | |||
path: | | |||
${{ steps.setup-haskell.outputs.cabal-store }} | |||
dist-newstyle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about having dist-newstyle
here now. I feel it may produce build errors due to accumulating builds' outputs. Or it may not. I'd leave it here for now, and remove if it starts giving us issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -8,6 +8,10 @@ on: | |||
# https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache | |||
branches: | |||
- main | |||
# GH caches are removed when not accessed within 7 days - this schedule runs the job every 6 days making | |||
# sure that we always have some caches on main | |||
schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can increase how long we hold on to caches for a in the repo settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this option. Artifacts and logs retention time can be configured, but I don't think caches can.
1512f8b
to
ae182ef
Compare
Changelog
Context
Make GHA cache restore any cache from current month if dependencies do not match.
Checklist