Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cardano-ledger and ouroboros-consensus for node-8.11.0 #523

Merged
merged 9 commits into from
May 14, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Apr 22, 2024

Changelog

- description: |
    Updated `cardano-ledger`, `ouroboros-consensus` and `plutus` packages.
    Added `FailT` dependency.
    Updated `conwayGenesisDefaults` and `alonzoGenesisDefaults`.
    Changed `CostModel` to use `Int64` instead of `Integer`.
    Fixed `ProtocolParameters` golden test to account for the `Integer` -> `Int64` change in the `CostModel`.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Lucsanszky Lucsanszky force-pushed the lucsanszky/integration-8.11 branch 2 times, most recently from 1a36f22 to 49a8e49 Compare May 1, 2024 00:32
@Lucsanszky Lucsanszky force-pushed the lucsanszky/integration-8.11 branch from 49a8e49 to 42d6f0f Compare May 2, 2024 00:13
@Lucsanszky Lucsanszky force-pushed the lucsanszky/integration-8.11 branch 4 times, most recently from d5f7a23 to b6487c4 Compare May 13, 2024 21:44
@Lucsanszky Lucsanszky changed the title Integrate latest cardano-ledger, ouroboros-network, ouroboros-consensus for node-8.11.0 (SRP) Integrate cardano-ledger and ouroboros-consensus for node-8.11.0 May 13, 2024
@Lucsanszky Lucsanszky force-pushed the lucsanszky/integration-8.11 branch from b6487c4 to 1ae4d2f Compare May 13, 2024 21:51
The `ucppPlutusV3CostModel` field was added to `UpgradeConwayPParams` by:
IntersectMBO/cardano-ledger@57bb4c1
The `Plutus` V3 cost model is supported from `Conway` onwards.
As we are hardforking into the `Conway` era, the V3 cost model
should now be moved from the `Alonzo` genesis file to `Conway`.
`cardano-ledger` no longer exports `CostModelApplyError`, so it
needs to be imported from `PlutusLedgerApi`.
See: IntersectMBO/cardano-ledger@dbb9f4e
The `Ouroboros.Consensus.Protocol.Praos.Translate` module was removed here:
IntersectMBO/ouroboros-consensus@7565499
@Lucsanszky Lucsanszky force-pushed the lucsanszky/integration-8.11 branch from 1ae4d2f to 33afca8 Compare May 13, 2024 23:23
@Lucsanszky Lucsanszky marked this pull request as ready for review May 13, 2024 23:25
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6d7285b May 14, 2024
26 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the lucsanszky/integration-8.11 branch May 14, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants