-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate cardano-ledger
and ouroboros-consensus
for node-8.11.0
#523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
2 times, most recently
from
May 1, 2024 00:32
1a36f22
to
49a8e49
Compare
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
from
May 2, 2024 00:13
49a8e49
to
42d6f0f
Compare
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
4 times, most recently
from
May 13, 2024 21:44
d5f7a23
to
b6487c4
Compare
Lucsanszky
changed the title
Integrate latest
Integrate May 13, 2024
cardano-ledger
, ouroboros-network
, ouroboros-consensus
for node-8.11.0
(SRP)cardano-ledger
and ouroboros-consensus
for node-8.11.0
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
from
May 13, 2024 21:51
b6487c4
to
1ae4d2f
Compare
disassembler
approved these changes
May 13, 2024
The `ucppPlutusV3CostModel` field was added to `UpgradeConwayPParams` by: IntersectMBO/cardano-ledger@57bb4c1
The `Plutus` V3 cost model is supported from `Conway` onwards. As we are hardforking into the `Conway` era, the V3 cost model should now be moved from the `Alonzo` genesis file to `Conway`.
`cardano-ledger` no longer exports `CostModelApplyError`, so it needs to be imported from `PlutusLedgerApi`. See: IntersectMBO/cardano-ledger@dbb9f4e
`mkCostModelsLenient` is now monadic. See: IntersectMBO/cardano-ledger@e173cf2
The `Ouroboros.Consensus.Protocol.Praos.Translate` module was removed here: IntersectMBO/ouroboros-consensus@7565499
Lucsanszky
force-pushed
the
lucsanszky/integration-8.11
branch
from
May 13, 2024 23:23
1ae4d2f
to
33afca8
Compare
Lucsanszky
requested review from
a team,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
carbolymer,
smelc,
palas and
kevinhammond
as code owners
May 13, 2024 23:25
CarlosLopezDeLara
approved these changes
May 14, 2024
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist