-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UTxO-HD targeting main #719
Open
jasagredo
wants to merge
1
commit into
master
Choose a base branch
from
utxo-hd-main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
a team,
dcoutts,
erikd,
kevinhammond,
CarlosLopezDeLara and
disassembler
as code owners
January 9, 2025 12:04
9 tasks
jasagredo
force-pushed
the
utxo-hd-main
branch
from
January 10, 2025 09:44
1af91cd
to
e3b7712
Compare
3 tasks
Jimbo4350
approved these changes
Jan 10, 2025
Jimbo4350
reviewed
Jan 10, 2025
jasagredo
force-pushed
the
utxo-hd-main
branch
from
January 21, 2025 14:03
e3b7712
to
9b40fb2
Compare
carbolymer
reviewed
Jan 22, 2025
Comment on lines
+83
to
+95
- name: Linux install lmdb | ||
if: matrix.sys.os == 'ubuntu-latest' | ||
run: sudo apt install liblmdb-dev | ||
|
||
- name: Mac install lmdb | ||
if: matrix.sys.os == 'macos-latest' | ||
run: brew install lmdb | ||
|
||
- name: Windows install lmdb | ||
if: matrix.sys.os == 'windows-latest' | ||
shell: 'C:/msys64/usr/bin/bash.exe -e {0}' | ||
run: /usr/bin/pacman --noconfirm -S mingw-w64-x86_64-lmdb | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go into input-output-hk/actions/base
to avoid having extra steps in multiple repos.
carbolymer
approved these changes
Jan 22, 2025
jasagredo
force-pushed
the
utxo-hd-main
branch
from
January 27, 2025 09:18
9b40fb2
to
1adad96
Compare
jasagredo
force-pushed
the
utxo-hd-main
branch
from
January 28, 2025 14:27
1adad96
to
3b4a3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Integrates the UTxO-HD changes in
cardano-api
. See the documentation for an extensive discussion on what the changes are and their implications.How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist