Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key non-extended-key: support CC keys #712

Closed
wants to merge 4 commits into from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Apr 10, 2024

Note

Needs IntersectMBO/cardano-api#514 merged and released and API update to be merged

Changelog

- description: |
    key non-extended-key: support CC keys
# uncomment types applicable to the change:
type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #705

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Apr 10, 2024

cc @disassembler

@smelc smelc force-pushed the smelc/key-non-extended-key-support-CC-keys branch from 036b37f to e6faf23 Compare April 10, 2024 12:27
@smelc
Copy link
Contributor Author

smelc commented Apr 15, 2024

Being integrated in #720, so will probably be closed soon.

@smelc
Copy link
Contributor Author

smelc commented Apr 22, 2024

Got superseded by #720 in the end

@smelc smelc closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key non-extended-key doesn't support extended CC keys
1 participant