Add --current-treasury-value and --treasury-donation to transaction build and friends #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
4 tasks
smelc
force-pushed
the
smelc/treasury-donations
branch
4 times, most recently
from
de41efe to
53f5350
Compare
smelc
force-pushed
the
smelc/treasury-donations
branch
4 times, most recently
from
110e911 to
7a16057
Compare
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
smelc
force-pushed
the
smelc/treasury-donations
branch
from
7a16057 to
528f47e
Compare
CarlosLopezDeLara
approved these changes
Jun 6, 2024
This was referenced Jun 7, 2024
smelc
force-pushed
the
smelc/treasury-donations
branch
from
528f47e to
2096e19
Compare
smelc
force-pushed
the
smelc/treasury-donations
branch
from
2096e19 to
b2b9781
Compare
Jimbo4350
requested changes
Jun 13, 2024
| @@ -735,14 +751,18 @@ runTxBuild :: () | |||
| -> Maybe Word | |||
| -> [(VotingProcedures era, Maybe (ScriptWitness WitCtxStake era))] | |||
| -> [(Proposal era, Maybe (ScriptWitness WitCtxStake era))] | |||
| -> Maybe TxCurrentTreasuryValue | |||
There was a problem hiding this comment.
So we are already querying the node state in transaction build command. What we should do is modify queryStateForBalancedTx to return the currency treasury value and this will allow us to avoid exposing a cli argument for the current treasury value.
build-raw will still need the argument however (as you've already done 👍 ).
There was a problem hiding this comment.
@Jimbo4350> OK I see, will do 👍
smelc
force-pushed
the
smelc/treasury-donations
branch
from
b2b9781 to
6762dbd
Compare
|
Putting draft until the required change in |
2 tasks
smelc
force-pushed
the
smelc/treasury-donations
branch
4 times, most recently
from
e6bda53 to
66ad2c5
Compare
…uilding functions
smelc
force-pushed
the
smelc/treasury-donations
branch
from
66ad2c5 to
1d055c5
Compare
Jimbo4350
approved these changes
Jul 1, 2024
| @@ -126,6 +128,7 @@ data TransactionBuildCmdArgs era = TransactionBuildCmdArgs | |||
| , mUpdateProposalFile :: !(Maybe (Featured ShelleyToBabbageEra era (Maybe UpdateProposalFile))) | |||
| , voteFiles :: ![(VoteFile In, Maybe (ScriptWitnessFiles WitCtxStake))] | |||
| , proposalFiles :: ![(ProposalFile In, Maybe (ScriptWitnessFiles WitCtxStake))] | |||
| , treasuryDonation :: !(Maybe TxTreasuryDonation) | |||
| txUpdateProposal mOverrideWits votingProcedures proposals _outputOptions = shelleyBasedEraConstraints sbe $ do | ||
| txUpdateProposal mOverrideWits votingProcedures proposals | ||
| mCurrentTreasuryValue mTreasuryDonation | ||
| _outputOptions = shelleyBasedEraConstraints sbe $ do |
There was a problem hiding this comment.
Separately, can you investigate why we ignore _outputOptions?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Fixes #590
How to trust this PR
We tested this new feature in
cardano-testnetin thiscardano-nodePR: IntersectMBO/cardano-node#5866Checklist
CurrentTreasuryValuetype from API instead of introducing a new one (see how API PR is received)