Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move genesis hash to hash genesis-file #982

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

palas
Copy link
Contributor

@palas palas commented Nov 28, 2024

Changelog

- description: |
    Moved `genesis hash` command to `hash genesis-file`
  type:
  - breaking

Context

This command was only accessible under era specific sub-commands, but itself is era independent. So this PR moves it to the hash subcommand, which is era independent.

How to trust this PR

Changes to golden files are most significative. The most important thing is probably the code remains the same in the new location, but it was copied. Then make sure the new command name is appropriate, and that you are happy with the old command locations not being available anymore.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas added the enhancement New feature or request label Nov 28, 2024
@palas palas self-assigned this Nov 28, 2024
@palas palas force-pushed the move-genesis-hash-to-hash-group branch from b0de7e7 to 7dc09c9 Compare November 28, 2024 15:14
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM so I'm approving but I'm wondering if we should leave the old command and just have it output era genesis hash is deprecated, please use hash genesis-file to be nice to users. And then only after the next release we remove it altogether. This is how we proceeded in the past.

cc @CarlosLopezDeLara

@palas palas requested a review from Jimbo4350 December 2, 2024 11:54
@palas palas force-pushed the move-genesis-hash-to-hash-group branch from a87fbf4 to e5b9136 Compare December 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants