-
Notifications
You must be signed in to change notification settings - Fork 163
Make it build with ghc-9.12 #1968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
erikd
wants to merge
8
commits into
master
Choose a base branch
from
erikd/ghc-9.12
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to be rebased on #1965 |
Still a draft, still a WIP 😀 |
e8def34
to
74da5a7
Compare
No longer needed. GHC has been deriving this typeclass for some time and ghc-9.12 now warns about it being redundant.
Needed to update the `cardano-node` dependency from `10.1.3` to `10.3` and use all the Cardano dependencies specified by `node`.
fae19b0
to
364bf1c
Compare
Co-Authored-By: Marcin Szamotulski <[email protected]> Co-Authored-By: Javier Sagredo <[email protected]>
8a9a1d1
to
2d95ac5
Compare
And remove redundant `allow-newer` stanzas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it build with ghc-9.12.
Not yet complete.
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.