Utxo hd #1999
Open
Utxo hd #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cmdv
previously approved these changes
Sep 4, 2025
sgillespie
reviewed
Sep 19, 2025
| lState <- decodeExt | ||
| eBlockNo <- fromCBOR | ||
| lTables <- valuesMKDecoder lState | ||
| pure $ CardanoLedgerState lState lTables eBlockNo |
There was a problem hiding this comment.
Do you think
CardanoLedgerState
<$> decodeExt
<*> valuesMKDecoder lstate
<*> fromCBOR
Reads better or worse?
There was a problem hiding this comment.
Actually forget I said that. It's a record, so I think it would be more maintainable with a record constructor.
sgillespie
reviewed
Sep 19, 2025
| deriving (Eq, Ord, Show, Functor) | ||
|
|
||
| type State block = Consensus.ExtLedgerState block | ||
| type State block = (Consensus.ExtLedgerState block EmptyMK, Consensus.LedgerTables (Consensus.ExtLedgerState block) ValuesMK) |
There was a problem hiding this comment.
Are the outer parentheses necessary?
kderme
force-pushed
the
utxo-hd
branch
2 times, most recently
from
455f611 to
b597717
Compare
Signed-off-by: Kostas Dermentzis <[email protected]>
This still suffers from IntersectMBO/ouroboros-consensus#1577 so Byron snapshots don't deserialise, until we update CHaP further Signed-off-by: Kostas Dermentzis <[email protected]>
Signed-off-by: Kostas Dermentzis <[email protected]>
Fixes the following error: > error: executing '/nix/store/xy4jjgw87sbgwylm5kn047d9gkbhsr9x-bash-5.2p37/bin/bash': > Argument list too long We are attempting to reduce the number of packages required for the shell by disabling haddock and hoogle. Longer term, it would be better to disable devShells for cross builds entirely. Signed-off-by: Kostas Dermentzis <[email protected]>
GHC 8.10 was dropped from Hydra (CI) some time ago, so it needs to be dropped from GitHub CI too. GHC 9.10 was broken a while ago in the upstream devShell (input-output-hk/devx), but hopefully it is fixed now. Signed-off-by: Kostas Dermentzis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #1998
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.