Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cardano-git-rev package #5727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove cardano-git-rev package #5727

wants to merge 3 commits into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Mar 26, 2024

Description

This package has been moved to the cardano-base repo.

However, after the move to base it was improved to make sure it operates correctly and then uploaded to CHaP.

Unfortunately I am not able to update the index-states in cabal.project because that causes a bunch of difficult to debug dependency solver failures.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

This package has been moved to the `cardano-base` repo.
@erikd erikd requested a review from a team as a code owner March 26, 2024 06:43
@erikd erikd requested review from carbolymer and Jimbo4350 and removed request for a team March 26, 2024 07:08
@erikd erikd closed this Mar 26, 2024
@erikd
Copy link
Contributor Author

erikd commented Mar 26, 2024

This just a mess.

@erikd erikd reopened this Mar 26, 2024
@erikd erikd requested a review from a team as a code owner March 26, 2024 08:49
@erikd erikd requested review from a team as code owners March 26, 2024 23:29
@smelc
Copy link
Contributor

smelc commented Mar 27, 2024

Superseded by #5716

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 12, 2024
@github-actions github-actions bot removed the Stale label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants