Refactor testnet SPO certificates functions #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
commented
Mar 28, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Show resolved
Hide resolved
carbolymer
commented
Mar 28, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/LedgerEvents/Gov/InfoAction.hs
Outdated
Show resolved
Hide resolved
smelc
reviewed
Mar 29, 2024
...ano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Babbage/LeadershipSchedule.hs
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Conway/DRepRetirement.hs
Show resolved
Hide resolved
| @@ -64,7 +58,7 @@ hprop_drep_retirement = H.integrationRetryWorkspace 2 "drep-retirement" $ \tempA | |||
| TestnetRuntime | |||
| { testnetMagic | |||
| , poolNodes | |||
| , wallets | |||
| , wallets=wallet0:_ | |||
There was a problem hiding this comment.
Haha nice trick to avoid the !!/head below!
|
Note: it is probably conflicting with #5732 |
carbolymer
force-pushed
the
mgalazyn/refactor/testnet-spo-functions
branch
2 times, most recently
from
4278448 to
dcd6ae1
Compare
smelc
approved these changes
Mar 29, 2024
newhoggy
reviewed
Mar 31, 2024
| @@ -64,7 +57,7 @@ hprop_drep_retirement = H.integrationRetryWorkspace 2 "drep-retirement" $ \tempA | |||
| TestnetRuntime | |||
| { testnetMagic | |||
| , poolNodes | |||
| , wallets | |||
| , wallets=wallet0:_ | |||
There was a problem hiding this comment.
This can still fail right? What happens when it does? Do you get nice output?
There was a problem hiding this comment.
It just prints:
Pattern match failure in 'do' block at test/cardano-testnet-test/Cardano/Testnet/Test/SubmitApi/Babbage/Transaction.hs:(68,3)-(73,5)
This is a testnet setup so it's pretty easy to spot on when working on a test.
There was a problem hiding this comment.
Ideally we should use a dependent list here.
carbolymer
force-pushed
the
mgalazyn/refactor/testnet-spo-functions
branch
from
dcd6ae1 to
2a0ef9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses new CLI format and supports Conway era. Remove redundant usage of
CPPextensions.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.