Node release 8.10 #5734
Merged
Node release 8.10 #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
disassembler
force-pushed
the
dnadales/node-8.10
branch
from
eeed7af to
5c68180
Compare
dnadales
force-pushed
the
dnadales/node-8.10
branch
from
5c68180 to
b18169c
Compare
carbolymer
reviewed
Apr 2, 2024
| @@ -77,6 +77,7 @@ import Data.Set (Set) | |||
| import qualified Data.Set as Set | |||
| import Data.Text (Text) | |||
| import qualified Data.Text.Encoding as Text | |||
| import GHC.IsList (toList) | |||
There was a problem hiding this comment.
Suggested change
| import GHC.IsList (toList) | |
| import GHC.Exts (toList) |
Needed for 8.10 support
amesgen
reviewed
Apr 2, 2024
disassembler
force-pushed
the
dnadales/node-8.10
branch
from
5e7b85d to
08bed1f
Compare
carbolymer
force-pushed
the
dnadales/node-8.10
branch
2 times, most recently
from
9f96c6f to
2fbd919
Compare
carbolymer
reviewed
Apr 2, 2024
carbolymer
force-pushed
the
dnadales/node-8.10
branch
from
2fbd919 to
ba0dd86
Compare
carbolymer
reviewed
Apr 2, 2024
| @@ -181,7 +182,7 @@ defaultConwayGenesis = | |||
| , ucppGovActionDeposit = Coin 1_000_000 | |||
| , ucppDRepDeposit = Coin 1_000_000 | |||
| , ucppDRepActivity = EpochInterval 100 | |||
| , ucppMinFeeRefScriptCostPerByte = undefined | |||
| , ucppMinFeeRefScriptCostPerByte = 0 %! 1 -- FIXME GARBAGE VALUE | |||
There was a problem hiding this comment.
I'm unsure about this 0 here. This needs to be updated after benchmarking. Same applies to genesis files below.
disassembler
force-pushed
the
dnadales/node-8.10
branch
6 times, most recently
from
651461b to
423db61
Compare
Jimbo4350
reviewed
Apr 5, 2024
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/Babbage/Transaction.hs
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Cli/KesPeriodInfo.hs
Show resolved
Hide resolved
Jimbo4350
approved these changes
Apr 5, 2024
dnadales
force-pushed
the
dnadales/node-8.10
branch
from
dd96a29 to
6ee3140
Compare
disassembler
force-pushed
the
dnadales/node-8.10
branch
from
6ee3140 to
5bc7e76
Compare
disassembler
force-pushed
the
dnadales/node-8.10
branch
from
5bc7e76 to
eb7f015
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.