Update checkStakeKeyRegistered to use foldEpochState
#5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
4 times, most recently
from
1b9cbaa to
2a31775
Compare
Jimbo4350
changed the title
checkStakeKeyRegistered to use foldEpochState
smelc
reviewed
Mar 29, 2024
Comment on lines
123
to
130
| H.failWithCustom GHC.callStack Nothing | ||
| $ unlines [ "Stake address in question: " | ||
| , Text.unpack (serialiseToBech32 sAddr) | ||
| , "was not registered" | ||
| , "Current stake info for address in question: " | ||
| , show $ map serialiseToBech32 $ Map.keys rewardsMap | ||
| , "foldEpochStateError: " <> show e | ||
| ] |
There was a problem hiding this comment.
Providing a detailed error message, nice 👍
smelc
approved these changes
Mar 29, 2024
carbolymer
reviewed
Mar 29, 2024
Comment on lines
120
to
122
| pledgerStakeInfo <- H.leftFailM $ H.readJsonFile oFpAbs | ||
| (DelegationsAndRewards (rewardsMap, _delegMap)) | ||
| <- H.noteShowM $ H.jsonErrorFail $ Aeson.fromJSON @DelegationsAndRewards pledgerStakeInfo |
There was a problem hiding this comment.
can be simplified a bit
Suggested change
| pledgerStakeInfo <- H.leftFailM $ H.readJsonFile oFpAbs | |
| (DelegationsAndRewards (rewardsMap, _delegMap)) | |
| <- H.noteShowM $ H.jsonErrorFail $ Aeson.fromJSON @DelegationsAndRewards pledgerStakeInfo | |
| (DelegationsAndRewards (rewardsMap, _delegMap)) <- H.noteShowM $ H.readJsonFileOk oFpAbs |
carbolymer
reviewed
Mar 29, 2024
Comment on lines
363
to
381
| -- TODO: Currently we can't propagate the error message thrown by checkStakeKeyRegistered when using byDurationM | ||
| -- Instead we wait 15 seconds |
There was a problem hiding this comment.
This TODO is obsolete now
Suggested change
| -- TODO: Currently we can't propagate the error message thrown by checkStakeKeyRegistered when using byDurationM | |
| -- Instead we wait 15 seconds | |
| -- TODO: Currently we can't propagate the error message thrown by checkStakeKeyRegistered when using byDurationM | |
| -- Instead we wait 15 seconds |
carbolymer
approved these changes
Mar 29, 2024
Jimbo4350
force-pushed
the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
from
2a31775 to
537398e
Compare
Jimbo4350
force-pushed
the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
from
315143e to
4d2913c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
There are build failures in merge queue https://github.com/IntersectMBO/cardano-node/actions/runs/8605681309/job/23582460168#step:13:594 |
Jimbo4350
force-pushed
the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
2 times, most recently
from
df25397 to
4d11b5e
Compare
Jimbo4350
force-pushed
the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
from
4d11b5e to
71537f5
Compare
Jimbo4350
deleted the
jordan/update-checkStakeKeyRegistered-to-use-foldEpochState
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.