-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove manual DRep registration from InfoAction test #5749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
added
the
minorfix
Something that needs to be fixed (e.g. a hard-coded constant), but that isnt a bug
label
Apr 4, 2024
smelc
approved these changes
Apr 5, 2024
palas
force-pushed
the
fix-update-info-test
branch
from
April 5, 2024 23:19
590f989
to
81846e7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 6, 2024
palas
force-pushed
the
fix-update-info-test
branch
4 times, most recently
from
April 6, 2024 04:52
81846e7
to
5bd9f8e
Compare
palas
force-pushed
the
fix-update-info-test
branch
from
April 8, 2024 15:59
5bd9f8e
to
31111a0
Compare
palas
force-pushed
the
fix-update-info-test
branch
from
April 8, 2024 18:00
31111a0
to
f0ef60a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Apr 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 9, 2024
carbolymer
approved these changes
Apr 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Apr 9, 2024
palas
force-pushed
the
fix-update-info-test
branch
from
April 9, 2024 19:22
f0ef60a
to
553e542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
InfoAction
test to not create its own DReps (this probably was not updated by #5732 because the test is commented out so it doesn't fail)Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7