Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden tests for Cardano.Tracing.OrphanInstances.Shelley #5775

Closed
wants to merge 1 commit into from

Conversation

neilmayhew
Copy link

@neilmayhew neilmayhew commented Apr 10, 2024

Description

Test some ToJSON instances that are due to be moved to ledger (see #5772 and IntersectMBO/cardano-ledger#4250). These tests will ensure that the serialization is unchanged before and after integration.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated.
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@neilmayhew neilmayhew requested a review from a team as a code owner April 10, 2024 16:53
@neilmayhew neilmayhew requested a review from smelc April 10, 2024 16:53
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @neilmayhew for the spinoff of #5772 👍

@smelc
Copy link
Contributor

smelc commented Apr 11, 2024

It needs a rebase and it's good to go, please enqueue for merge when you see fit @neilmayhew

@neilmayhew neilmayhew force-pushed the neilmayhew/orphan-golden-tests branch from 0e68431 to bb6a254 Compare April 11, 2024 13:20
@neilmayhew neilmayhew enabled auto-merge April 11, 2024 13:21
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 27, 2024
@neilmayhew neilmayhew force-pushed the neilmayhew/orphan-golden-tests branch from bb6a254 to 5388f1e Compare May 27, 2024 23:24
@neilmayhew neilmayhew disabled auto-merge May 27, 2024 23:26
@github-actions github-actions bot removed the Stale label May 28, 2024
@neilmayhew neilmayhew marked this pull request as draft May 28, 2024 13:40
@neilmayhew
Copy link
Author

There's no longer any need for this to be merged. It's testing functionality that's no longer part of node because it's been moved to ledger and the functionality has tests in ledger. These golden tests were a temporary measure to ensure that the functionality hadn't changed during the move. Since the tests pass after this PR was rebased, we know the move was done correctly. We can therefore close this PR without merging it.

@neilmayhew neilmayhew closed this May 28, 2024
@neilmayhew neilmayhew deleted the neilmayhew/orphan-golden-tests branch May 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants