Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan golden tests #5776

Closed
wants to merge 3 commits into from

Conversation

neilmayhew
Copy link

Description

Remove golden tests of functionality that is now in ledger and has golden tests there.

This should be merged after #5772

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated.
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@neilmayhew neilmayhew requested a review from a team as a code owner April 10, 2024 16:56
@neilmayhew neilmayhew marked this pull request as draft April 10, 2024 16:57
@neilmayhew neilmayhew requested a review from smelc April 10, 2024 16:57
@neilmayhew neilmayhew force-pushed the neilmayhew/remove-orphan-golden-tests branch from 1d86d4a to 7c4be96 Compare April 11, 2024 13:25
@neilmayhew
Copy link
Author

cc @Lucsanszky

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label May 27, 2024
@neilmayhew neilmayhew force-pushed the neilmayhew/remove-orphan-golden-tests branch from 7c4be96 to 61ee43c Compare May 27, 2024 23:24
@github-actions github-actions bot removed the Stale label May 28, 2024
@neilmayhew
Copy link
Author

Superseded by recent integration

@neilmayhew neilmayhew closed this May 28, 2024
@neilmayhew neilmayhew deleted the neilmayhew/remove-orphan-golden-tests branch May 28, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant