Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factoring out RTView #5846

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Factoring out RTView #5846

merged 2 commits into from
Jul 19, 2024

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented May 17, 2024 •
edited
Loading

Description

This puts RTView behind a build flag. It is disabled by default and can be enabled with -f +rtview.

-rtview drops the dependency on threepenny-gui, and moves EKG monitoring to direct HTML rendering.

Restructure module hierarchies.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@Icelandjack Icelandjack requested review from a team as code owners May 17, 2024 11:22
@Icelandjack Icelandjack marked this pull request as draft May 17, 2024 11:27
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 2 times, most recently from 9b2145a to d828b0d Compare May 21, 2024 11:03
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 6 times, most recently from ddb1936 to fc65e70 Compare May 30, 2024 08:17
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 2 times, most recently from 475c280 to ed8e729 Compare June 4, 2024 16:33
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 5 times, most recently from 942990f to f013910 Compare June 27, 2024 16:31
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 12 times, most recently from 362ddf0 to 8981048 Compare July 3, 2024 14:31
@Icelandjack Icelandjack force-pushed the baldurb/rtview-opt branch 18 times, most recently from 01805ce to 44e9918 Compare July 17, 2024 09:03
@Icelandjack Icelandjack marked this pull request as ready for review July 17, 2024 09:04
mgmeier
mgmeier reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Icelandjack, thank you.

@mgmeier mgmeier added this pull request to the merge queue Jul 19, 2024
Merged via the queue into master with commit b161938 Jul 19, 2024
23 of 24 checks passed
@mgmeier mgmeier deleted the baldurb/rtview-opt branch July 19, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icelandjack @mgmeier